Fix "openGL lag at zoom 2000 + rotation"
08fd3aa8e554
Actions

Authored by dkazakov on Mar 25 2016, 12:08 PM.

Description

Fix "openGL lag at zoom 2000 + rotation"

The problem was not related to the openGL actualy. It was caused
by the implementation of QPainter::clipRegion() which generated
20k+ rectangles from a rotated rect when rotation angle was near to
a 0 or 90deg.

WARNING for the future:
Never use QPainter::clipRegion(). Use KisPaintingUtils::safeClipRegion()
instead. It workarounds the issue returning a bit bigger rect.

Fixes T1446
BUG:355104
CC:kimageshop@kde.org

Details

Committed

dkazakov

Mar 25 2016, 12:08 PM

Parents

R37:13df6317df7e: Fix a hangup when closing Krita when running LoD strokes

Branches

Unknown

Tags

Unknown

Tasks

T1446: considerable lag in navigation like panning and rotating canvas and even painting when user is zoomed over 200%

dkazakov committed R37:08fd3aa8e554: Fix "openGL lag at zoom 2000 + rotation" (authored by dkazakov).Mar 25 2016, 12:08 PM

dkazakov added a task: T1446: considerable lag in navigation like panning and rotating canvas and even painting when user is zoomed over 200%.

Changes (10)

				Path	Packages
	M			libs/flake/KoShapeContainer.cpp
	M			libs/flake/KoShapeManager.cpp
	M			libs/flake/tools/KoCreateShapeStrategy.cpp
	M			libs/flake/tools/KoShapeRubberSelectStrategy.cpp
	M			libs/global/CMakeLists.txt
	P			libs/global/kis_painting_tweaks.cpp Copied from libs/ui/canvas/kis_snap_config.cpp
	P			libs/global/kis_painting_tweaks.h Copied from libs/ui/dialogs/kis_delayed_save_dialog.h
	M			plugins/flake/textshape/TextShape.cpp
	M			plugins/flake/textshape/textlayout/KoTextLayoutArea_paint.cpp
	M			plugins/flake/vectorshape/VectorShape.cpp