diff --git a/plugins/tools/selectiontools/KisToolSelectMagnetic.cc b/plugins/tools/selectiontools/KisToolSelectMagnetic.cc index 292a448ad4..4de1557c09 100644 --- a/plugins/tools/selectiontools/KisToolSelectMagnetic.cc +++ b/plugins/tools/selectiontools/KisToolSelectMagnetic.cc @@ -1,480 +1,494 @@ /* * Copyright (c) 2019 Kuntal Majumder * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include "KisToolSelectMagnetic.h" #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include "kis_painter.h" #include #include "canvas/kis_canvas2.h" #include "kis_pixel_selection.h" #include "kis_selection_tool_helper.h" #include "kis_algebra_2d.h" #include "KisHandlePainterHelper.h" #include #define FEEDBACK_LINE_WIDTH 2 #define distBetween(x, y) kisDistance(pixelToView(m_points[x]), pixelToView(m_points[y])) KisToolSelectMagnetic::KisToolSelectMagnetic(KoCanvasBase *canvas) : KisToolSelect(canvas, KisCursor::load("tool_magnetic_selection_cursor.png", 5, 5), i18n("Magnetic Selection")), - m_continuedMode(false), m_complete(true), m_threshold(70), m_checkPoint(-1), m_frequency(30), m_radius(3.0) + m_continuedMode(false), m_complete(true), m_threshold(70), m_checkPoint(-1), m_frequency(30), m_radius(3.0), + m_radiusSliderCompressor(1000, KisSignalCompressor::FIRST_ACTIVE), m_mouseHoverCompressor(100, KisSignalCompressor::FIRST_ACTIVE) { } void KisToolSelectMagnetic::keyPressEvent(QKeyEvent *event) { if (event->key() == Qt::Key_Control) { m_continuedMode = true; } KisToolSelect::keyPressEvent(event); } void KisToolSelectMagnetic::keyReleaseEvent(QKeyEvent *event) { if (event->key() == Qt::Key_Control || !(event->modifiers() & Qt::ControlModifier)) { m_continuedMode = false; if (mode() != PAINT_MODE && !m_points.isEmpty()) { finishSelectionAction(); } } KisToolSelect::keyReleaseEvent(event); } /* * Calculates the checkpoints responsible to determining the last point from where * the edge is calculated. * Takes 3 point, min, median and max, searches for an edge point from median to max, if fails, * searches for the same from median to min, if fails, median becomes that edge point. */ void KisToolSelectMagnetic::calculateCheckPoints() { qreal totalDistance = 0.0; int finalPoint = m_checkPoint + 2; int midPoint = m_checkPoint + 1; int minPoint = m_checkPoint; - qreal maxFactor = 1.7; + qreal maxFactor = 2; for(; finalPoint maxFactor*m_frequency){ break; } } if(totalDistance > maxFactor*m_frequency){ bool foundSomething = false; for(int i = midPoint; i < finalPoint; i++){ if(m_worker.intensity(m_points.at(i).toPoint()) >= m_threshold){ m_checkPoint = i; m_lastAnchor = m_points.at(i).toPoint(); m_anchorPoints.push_back(i); foundSomething = true; break; } } if(!foundSomething){ for(int i = midPoint - 1; i>= minPoint; i--){ if(m_worker.intensity(m_points.at(i).toPoint()) >= m_threshold){ m_checkPoint = i; m_lastAnchor = m_points.at(i).toPoint(); m_anchorPoints.push_back(i); foundSomething = true; break; } } } if(!foundSomething && m_checkPoint >= 0){ m_checkPoint = midPoint; m_lastAnchor = m_points.at(m_checkPoint).toPoint(); m_anchorPoints.push_back(m_checkPoint); foundSomething = true; } } totalDistance = 0.0; for(; finalPoint maxFactor*m_frequency){ calculateCheckPoints(); totalDistance = 0.0; } } - } -// the cursor is still tracked even when no mousebutton is pressed -void KisToolSelectMagnetic::mouseMoveEvent(KoPointerEvent *event) +void KisToolSelectMagnetic::slotCalculateEdge() { - KisToolSelect::mouseMoveEvent(event); - if (m_complete) - return; - - m_lastCursorPos = convertToPixelCoord(event); QPoint current = m_lastCursorPos.toPoint(); vQPointF pointSet = m_worker.computeEdge(m_frequency, m_lastAnchor, current); m_points.resize(m_checkPoint); m_points.append(pointSet); calculateCheckPoints(); m_paintPath = QPainterPath(); m_paintPath.moveTo(pixelToView(m_points[0])); for (int i = 1; i < m_points.count(); i++) { m_paintPath.lineTo(pixelToView(m_points[i])); } updateFeedback(); if (m_continuedMode && mode() != PAINT_MODE) { updateContinuedMode(); } +} + +// the cursor is still tracked even when no mousebutton is pressed +void KisToolSelectMagnetic::mouseMoveEvent(KoPointerEvent *event) +{ + KisToolSelect::mouseMoveEvent(event); + if (m_complete) + return; + + m_lastCursorPos = convertToPixelCoord(event); + + m_mouseHoverCompressor.start(); + } // KisToolSelectMagnetic::mouseMoveEvent // press primary mouse button void KisToolSelectMagnetic::beginPrimaryAction(KoPointerEvent *event) { setMode(KisTool::PAINT_MODE); QPointF temp(convertToPixelCoord(event)); m_lastAnchor = QPoint((int) temp.x(), (int) temp.y()); m_checkPoint = m_points.count() == 0 ? 0 : m_points.count() - 1; if (m_anchorPoints.count() == 0) { m_snapBound = QRect(QPoint(0, 0), QSize(10, 10)); m_snapBound.moveCenter(m_lastAnchor); } if (m_anchorPoints.count() > 0 && m_snapBound.contains(m_lastAnchor)) { m_complete = true; finishSelectionAction(); return; } m_anchorPoints.push_back(m_checkPoint); m_complete = false; updateCanvasPixelRect(image()->bounds()); } // drag while primary mouse button is pressed void KisToolSelectMagnetic::continuePrimaryAction(KoPointerEvent *event) { KisToolSelectBase::continuePrimaryAction(event); } // release primary mouse button void KisToolSelectMagnetic::endPrimaryAction(KoPointerEvent *event) { KisToolSelectBase::endPrimaryAction(event); } void KisToolSelectMagnetic::finishSelectionAction() { KisCanvas2 *kisCanvas = dynamic_cast(canvas()); KIS_ASSERT_RECOVER_RETURN(kisCanvas); kisCanvas->updateCanvas(); setMode(KisTool::HOVER_MODE); //just for testing out - //m_worker.saveTheImage(m_points); + m_worker.saveTheImage(m_points); QRectF boundingViewRect = pixelToView(KisAlgebra2D::accumulateBounds(m_points)); KisSelectionToolHelper helper(kisCanvas, kundo2_i18n("Magnetic Selection")); if (m_points.count() > 2 && !helper.tryDeselectCurrentSelection(boundingViewRect, selectionAction())) { QApplication::setOverrideCursor(KisCursor::waitCursor()); const SelectionMode mode = helper.tryOverrideSelectionMode(kisCanvas->viewManager()->selection(), selectionMode(), selectionAction()); if (mode == PIXEL_SELECTION) { KisPixelSelectionSP tmpSel = KisPixelSelectionSP(new KisPixelSelection()); KisPainter painter(tmpSel); painter.setPaintColor(KoColor(Qt::black, tmpSel->colorSpace())); painter.setAntiAliasPolygonFill(antiAliasSelection()); painter.setFillStyle(KisPainter::FillStyleForegroundColor); painter.setStrokeStyle(KisPainter::StrokeStyleNone); painter.paintPolygon(m_points); QPainterPath cache; cache.addPolygon(m_points); cache.closeSubpath(); tmpSel->setOutlineCache(cache); helper.selectPixelSelection(tmpSel, selectionAction()); } else { KoPathShape *path = new KoPathShape(); path->setShapeId(KoPathShapeId); QTransform resolutionMatrix; resolutionMatrix.scale(1 / currentImage()->xRes(), 1 / currentImage()->yRes()); path->moveTo(resolutionMatrix.map(m_points[0])); for (int i = 1; i < m_points.count(); i++) path->lineTo(resolutionMatrix.map(m_points[i])); path->close(); path->normalize(); helper.addSelectionShape(path, selectionAction()); } QApplication::restoreOverrideCursor(); } m_points.clear(); m_anchorPoints.clear(); m_paintPath = QPainterPath(); } // KisToolSelectMagnetic::finishSelectionAction void KisToolSelectMagnetic::paint(QPainter& gc, const KoViewConverter &converter) { Q_UNUSED(converter); if ((mode() == KisTool::PAINT_MODE || m_continuedMode) && !m_points.isEmpty()) { QPainterPath outline = m_paintPath; if (m_continuedMode && mode() != KisTool::PAINT_MODE) { outline.lineTo(pixelToView(m_lastCursorPos)); } paintToolOutline(&gc, outline); //printing the handles bool firstPoint = true; Q_FOREACH (const int pt, m_anchorPoints) { if(pt < 0){ //no points are set continue; } KisHandlePainterHelper helper(&gc, handleRadius()); if(m_snapBound.contains(m_lastCursorPos) && firstPoint){ helper.setHandleStyle(KisHandleStyle::secondarySelection()); helper.drawHandleRect(pixelToView(m_points[pt]), 4, QPoint(0,0)); firstPoint = false; continue; } helper.setHandleStyle(KisHandleStyle::primarySelection()); helper.drawHandleRect(pixelToView(m_points[pt]), 4, QPoint(0,0)); } } } void KisToolSelectMagnetic::updateFeedback() { if (m_points.count() > 1) { qint32 lastPointIndex = m_points.count() - 1; QRectF updateRect = QRectF(m_points[lastPointIndex - 1], m_points[lastPointIndex]).normalized(); updateRect = kisGrowRect(updateRect, FEEDBACK_LINE_WIDTH); updateCanvasPixelRect(updateRect); } } void KisToolSelectMagnetic::updateContinuedMode() { if (!m_points.isEmpty()) { qint32 lastPointIndex = m_points.count() - 1; QRectF updateRect = QRectF(m_points[lastPointIndex - 1], m_lastCursorPos).normalized(); updateRect = kisGrowRect(updateRect, FEEDBACK_LINE_WIDTH); updateCanvasPixelRect(updateRect); } } void KisToolSelectMagnetic::activate(KoToolBase::ToolActivation activation, const QSet &shapes) { m_worker = KisMagneticWorker(image()->projection(), m_radius); m_configGroup = KSharedConfig::openConfig()->group(toolId()); connect(action("undo_polygon_selection"), SIGNAL(triggered()), SLOT(undoPoints()), Qt::UniqueConnection); + connect(&m_radiusSliderCompressor, SIGNAL(timeout()), this, SLOT(slotUpdateRadius())); + connect(&m_mouseHoverCompressor, SIGNAL(timeout()), this, SLOT(slotCalculateEdge())); KisToolSelect::activate(activation, shapes); } void KisToolSelectMagnetic::deactivate() { KisCanvas2 *kisCanvas = dynamic_cast(canvas()); KIS_ASSERT_RECOVER_RETURN(kisCanvas); kisCanvas->updateCanvas(); m_continuedMode = false; m_complete = true; disconnect(action("undo_polygon_selection"), 0, this, 0); KisTool::deactivate(); } void KisToolSelectMagnetic::undoPoints() { if (m_complete) return; m_anchorPoints.pop_back(); m_lastAnchor = m_points[m_anchorPoints.last()].toPoint(); m_checkPoint = m_anchorPoints.last(); updateCanvasPixelRect(image()->bounds()); } void KisToolSelectMagnetic::requestStrokeEnd() { if (m_complete) return; m_complete = true; finishSelectionAction(); } void KisToolSelectMagnetic::requestStrokeCancellation() { setMode(KisTool::HOVER_MODE); m_complete = true; m_points.clear(); m_anchorPoints.clear(); m_paintPath = QPainterPath(); updateCanvasPixelRect(image()->bounds()); } QWidget * KisToolSelectMagnetic::createOptionWidget() { KisToolSelectBase::createOptionWidget(); KisSelectionOptions *selectionWidget = selectionOptionWidget(); QHBoxLayout *f1 = new QHBoxLayout(); QLabel *lblRad = new QLabel(i18n("Radius: "), selectionWidget); f1->addWidget(lblRad); KisDoubleSliderSpinBox *radInput = new KisDoubleSliderSpinBox(selectionWidget); radInput->setObjectName("radius"); radInput->setRange(2.5, 100.0, 2); radInput->setSingleStep(0.5); radInput->setToolTip("Radius of the filter for the detecting edges, might take some time to calculate"); f1->addWidget(radInput); connect(radInput, SIGNAL(valueChanged(qreal)), this, SLOT(slotSetRadius(qreal))); QHBoxLayout *f2 = new QHBoxLayout(); QLabel *lblThreshold = new QLabel(i18n("Threshold: "), selectionWidget); f2->addWidget(lblThreshold); KisSliderSpinBox *threshInput = new KisSliderSpinBox(selectionWidget); threshInput->setObjectName("threshold"); threshInput->setRange(1, 255); threshInput->setSingleStep(10); threshInput->setToolTip("Threshold for determining the minimum intensity of the edges"); f2->addWidget(threshInput); connect(threshInput, SIGNAL(valueChanged(int)), this, SLOT(slotSetThreshold(int))); QHBoxLayout *f3 = new QHBoxLayout(); QLabel *lblFrquency = new QLabel(i18n("Anchor Gap: "), selectionWidget); f3->addWidget(lblFrquency); KisSliderSpinBox *freqInput = new KisSliderSpinBox(selectionWidget); freqInput->setObjectName("frequency"); freqInput->setRange(20, 200); freqInput->setSingleStep(10); freqInput->setToolTip("Average distance between 2 anchors in screen pixels"); freqInput->setSuffix(" px"); f3->addWidget(freqInput); connect(freqInput, SIGNAL(valueChanged(int)), this, SLOT(slotSetFrequency(int))); QVBoxLayout *l = dynamic_cast(selectionWidget->layout()); Q_ASSERT(l); l->insertLayout(1, f1); l->insertLayout(2, f2); l->insertLayout(3, f3); radInput->setValue(m_configGroup.readEntry("radius", 3.0)); threshInput->setValue(m_configGroup.readEntry("threshold", 100)); freqInput->setValue(m_configGroup.readEntry("frequency", 30)); return selectionWidget; } // KisToolSelectMagnetic::createOptionWidget void KisToolSelectMagnetic::slotSetRadius(qreal r) { + m_radiusSliderCompressor.start(); m_radius = r; - m_worker = KisMagneticWorker(image()->projection(), m_radius); m_configGroup.writeEntry("radius", r); } void KisToolSelectMagnetic::slotSetThreshold(int t) { m_threshold = t; m_configGroup.writeEntry("threshold", t); } void KisToolSelectMagnetic::slotSetFrequency(int f) { m_frequency = f; m_configGroup.writeEntry("frequency", f); } +void KisToolSelectMagnetic::slotUpdateRadius() +{ + m_worker = KisMagneticWorker(image()->projection(), m_radius); +} + void KisToolSelectMagnetic::resetCursorStyle() { if (selectionAction() == SELECTION_ADD) { useCursor(KisCursor::load("tool_magnetic_selection_cursor_add.png", 6, 6)); } else if (selectionAction() == SELECTION_SUBTRACT) { useCursor(KisCursor::load("tool_magnetic_selection_cursor_sub.png", 6, 6)); } else { KisToolSelect::resetCursorStyle(); } } diff --git a/plugins/tools/selectiontools/KisToolSelectMagnetic.h b/plugins/tools/selectiontools/KisToolSelectMagnetic.h index 796a0dde1a..b337c40f34 100644 --- a/plugins/tools/selectiontools/KisToolSelectMagnetic.h +++ b/plugins/tools/selectiontools/KisToolSelectMagnetic.h @@ -1,116 +1,120 @@ /* * Copyright (c) 2019 Kuntal Majumder * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #ifndef KIS_TOOL_SELECT_MAGNETIC_H_ #define KIS_TOOL_SELECT_MAGNETIC_H_ #include #include "KisSelectionToolFactoryBase.h" #include #include +#include #include "KisMagneticWorker.h" class QPainterPath; class KisToolSelectMagnetic : public KisToolSelect { Q_OBJECT public: KisToolSelectMagnetic(KoCanvasBase *canvas); ~KisToolSelectMagnetic() override = default; void beginPrimaryAction(KoPointerEvent *event) override; void continuePrimaryAction(KoPointerEvent *event) override; void endPrimaryAction(KoPointerEvent *event) override; void paint(QPainter& gc, const KoViewConverter &converter) override; void keyPressEvent(QKeyEvent *event) override; void keyReleaseEvent(QKeyEvent *event) override; void mouseMoveEvent(KoPointerEvent *event) override; void resetCursorStyle() override; void requestStrokeEnd() override; void requestStrokeCancellation() override; QWidget * createOptionWidget() override; public Q_SLOTS: void deactivate() override; void activate(KoToolBase::ToolActivation activation, const QSet &shapes) override; void undoPoints(); void slotSetRadius(qreal); void slotSetThreshold(int); void slotSetFrequency(int); + void slotUpdateRadius(); + void slotCalculateEdge(); protected: using KisToolSelectBase::m_widgetHelper; private: void finishSelectionAction(); void updateFeedback(); void updateContinuedMode(); void updateCanvas(); void calculateCheckPoints(); QPainterPath m_paintPath; QVector m_points; QVector m_anchorPoints; bool m_continuedMode; QPointF m_lastCursorPos; QPoint m_lastAnchor; bool m_complete; KisMagneticWorker m_worker; int m_threshold, m_checkPoint, m_frequency; qreal m_radius; QRectF m_snapBound; KConfigGroup m_configGroup; + KisSignalCompressor m_radiusSliderCompressor, m_mouseHoverCompressor; }; class KisToolSelectMagneticFactory : public KisSelectionToolFactoryBase { public: KisToolSelectMagneticFactory() : KisSelectionToolFactoryBase("KisToolSelectMagnetic") { setToolTip(i18n("Magnetic Selection Tool")); setSection(TOOL_TYPE_SELECTION); setIconName(koIconNameCStr("tool_magnetic_selection")); setPriority(8); setActivationShapeId(KRITA_TOOL_ACTIVATION_ID); } ~KisToolSelectMagneticFactory() override { } KoToolBase * createTool(KoCanvasBase *canvas) override { return new KisToolSelectMagnetic(canvas); } QList createActionsImpl() override { KisActionRegistry *actionRegistry = KisActionRegistry::instance(); QList actions = KisSelectionToolFactoryBase::createActionsImpl(); actions << actionRegistry->makeQAction("undo_polygon_selection"); return actions; } }; #endif // __selecttoolmagnetic_h__