Diffusion Ark df024e3d1375

ReadWriteLibarchivePlugin: stop calling QSaveFile::commit() on fail
df024e3d1375
Actions

Authored by elvisangelaccio on Jun 1 2019, 4:32 PM.

Tags

None

Subscribers

None

Description

ReadWriteLibarchivePlugin: stop calling QSaveFile::commit() on fail

If we just called QSaveFile::cancelWriting(), there is nothing to be
commited on disk.

Details

Committed

elvisangelaccio

Jun 2 2019, 8:39 AM

Parents

R36:1ef661a12e22: ReadWriteLibarchivePlugin: bring back an old TODO

Branches

Unknown

Tags

Unknown

elvisangelaccio committed R36:df024e3d1375: ReadWriteLibarchivePlugin: stop calling QSaveFile::commit() on fail (authored by elvisangelaccio).Jun 2 2019, 8:39 AM

elvisangelaccio mentioned this in T10987: [Libarchive] Compression of a large file cannot be stopped.Jun 2 2019, 8:51 AM

elvisangelaccio mentioned this in T10988: [ReadWriteLibarchivePlugin] Fix memory handling (QSaveFile + ArchiveWrite).

Changes (1)

				Path	Packages
	M			plugins/libarchive/readwritelibarchiveplugin.cpp

R36:df024e3d1375

plugins/libarchive/readwritelibarchiveplugin.cpp

Loading...