Diffusion Ark 31b5501b02b1

Don't show comment message widget after clearing the comment view

Authored by elvisangelaccio on Jul 22 2018, 8:50 PM.

Description

Don't show comment message widget after clearing the comment view

The comment message widget is supposed to be visible after the user
edits an existing comment. However the current logic makes it visible
even after opening two archives with a comment in a row:

  1. The first time the message widget is hidden as expected, because it was explicitly hidden in the Part ctor and m_commentBox->show() in slotShowComment() still leaves it hidden.
  1. The second time, the message widget is breafly shown is slotCommentChanged() because m_commentView->toPlainText() is empty (it gets cleared before opening the second archive). The message widgets stays visibile because it's not hidden anywhere else.

This patch fixes the issue by preventing that the message widget gets shown
*without reason* in the first place.

Details

Committed
elvisangelaccioJul 22 2018, 9:00 PM
Parents
R36:cfee2c4483fc: libzip: use ZIP_FL_ENC_RAW for comments
Branches
Unknown
Tags
Unknown