Add a "clear" button and related code for the OutputView

Authored by tcanabrava on Jan 13 2017, 5:39 PM.

Description

Add a "clear" button and related code for the OutputView

Summary:
Adds a clear button and related code for the OutputView,
sometimes the amount of text inside of the OutputView is just
too much and we wanna clear, not filter, the dialog to be
able to look at new strings comming in.

Also, a few cleanups on some files regarding dead code and
micro-opts.

Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org>

Test Plan: manual testing

Reviewers: kfunk, apol

Subscribers: kdevelop-devel

Differential Revision: https://phabricator.kde.org/D4126

Details

Auditors
kfunk
Committed
tcanabravaJan 15 2017, 12:45 PM
Differential Revision
D4126: Add a "clear" button and related code for the OutputView
Parents
R33:5ddc8c7ed86b: Clean unused code.
Branches
Unknown
Tags
Unknown
kfunk raised a concern with this commit.EditedJan 16 2017, 9:48 AM
kfunk added a subscriber: kfunk.

Breaks tests:

FAIL!  : StandardOutputViewTest::testActions() Compared values are not the same
   Actual   (actions.size()): 11
   Expected (10)            : 10
   Loc: [/home/jenkins/sources/kdevplatform/kf5-qt5/plugins/standardoutputview/tests/test_standardoutputview.cpp(115)]

See: https://build.kde.org/view/Kdevelop/job/kdevplatform%20master%20kf5-qt5/230/PLATFORM=Linux,compiler=gcc/testReport/junit/(root)/TestSuite/test_standardoutputview/

Please fix.

kfunk added a subscriber: KDevelop.Jan 16 2017, 9:48 AM
kfunk accepted this commit.Jan 16 2017, 11:56 AM

Fixed with D4155.