Use {} as default value for zero-set flags, not nullptr

Authored by kossebau on Mar 23 2017, 9:19 PM.

Description

Use {} as default value for zero-set flags, not nullptr

Summary:
For some human code readers nullptr seems akward with bitflags,
(even more as QFlags is int-based -> sizeof). On quick reading
seeing a nullptr with unknown type even might result in wrong
assumption of a pointer type.
So for mental sanity of some of us using default constructor instead,
which still needs people to know it defaults to no bits set,
but that might be expected, as 0 is a usual default.

Reviewers: KDevelop, kfunk

Reviewed By: KDevelop, kfunk

Subscribers: kfunk, kdevelop-devel

Differential Revision: https://phabricator.kde.org/D5161

Details

Committed
kossebauMar 24 2017, 12:24 AM
Reviewer
KDevelop
Differential Revision
D5161: Use {} as default value for zero-set flags, not nullptr
Parents
R33:19875d9916f2: Remove unused Qt::WindowFlags parameters from internal API
Branches
Unknown
Tags
Unknown