Diffusion KDevelop d91e22649ab1

patchreview: Allow to translate string
d91e22649ab1
Actions

Authored by kfunk on Dec 10 2018, 8:14 AM.

Description

patchreview: Allow to translate string

Details

Committed
kfunkDec 10 2018, 8:14 AM
Parents
R32:a41f7c00535a: Merge remote-tracking branch 'origin/5.3'
Branches
Unknown
Tags
Unknown
Reverted By
R32:2bd71e5f79ac: Revert "patchreview: Allow to translate string"
pino added a subscriber: pino.Dec 10 2018, 8:21 AM
pino added inline comments.
/plugins/patchreview/patchreviewtoolview.cpp
142

Is this string sent to any online patch/review system? If so, it may be a better idea to leave it untranslated, otherwise it will reflect the language of the user sending the patch, not the language of the actual patch/review system.

kfunk marked an inline comment as done.Dec 10 2018, 8:46 AM

@pino I actually thought about the same, but was unsure since Aleix asked to have it translated. I agree with your explanation, it makes sense to have this not translated at all. Will revert.

Changes (1)

PathPackages
Mplugins/patchreview/patchreviewtoolview.cpp

R32:d91e22649ab1

View Options

plugins/patchreview/patchreviewtoolview.cpp

Loading...