Fix removal of external scripts

Authored by amhndu on Sep 25 2018, 7:08 PM.

Description

Fix removal of external scripts

Summary:
Previously, deleting a script which is in the middle of the config would invalidate indices
of the scripts that come after it in the config, this would mean deleting
anything later deletes the wrong script.

The config labels are now stored in the model itself and is no longer based on just the index,
but on the name of the script. Thus, deleting/updating one script does not interfere with the
other scripts.

BUG: 385298

Test Plan:

  • Before applying the patch:
    • Delete "Google Selection"
    • Restart
    • Delete "Quick Compile"
    • Restart and check list of external scripts
  • Apply the patch and repeat.

Reviewers: KDevelop, flherne

Reviewed By: KDevelop, flherne

Subscribers: flherne, kdevelop-devel

Tags: KDevelop

Differential Revision: https://phabricator.kde.org/D15743

Details

Committed
amhnduSep 28 2018, 2:58 PM
Reviewer
KDevelop
Differential Revision
D15743: Fix removal of external scripts
Parents
R32:030545919cde: Sublime: Rename private member of IdealButtonBarLayout for consistency
Branches
Unknown
Tags
Unknown