Fix crash deep inside VcsOverlayProxyModel::data()

Authored by kfunk on Nov 16 2017, 4:49 PM.

Description

Fix crash deep inside VcsOverlayProxyModel::data()

Summary:
VcsOverlayProxyModel::data() calls ProjectController::changesModel()
which currently is a non-const method which might create an instance
of ProjectChangesModel which in turn triggers some KJobs.

Avoid that by instantiating ProjectChangesModel() immediately during
startup. I don't think that has a real performance impact.

BUG: 384162
FIXED-IN: 5.2.1

Reviewers: apol

Reviewed By: apol

Subscribers: mwolff, dfaure, brauch, apol, kdevelop-devel

Differential Revision: https://phabricator.kde.org/D8852

Details

Committed
kfunkNov 20 2017, 8:30 PM
Reviewer
apol
Differential Revision
D8852: Fix crash deep inside VcsOverlayProxyModel::data()
Parents
R32:53ec893e8271: compute itemrepository version from version plus KDEVELOP_VERSION
Branches
Unknown
Tags
Unknown