Fix undefined behavior and set QT_MIN_VERSION to 5.9.0

Authored by mglb on Mar 21 2019, 2:30 AM.

Description

Fix undefined behavior and set QT_MIN_VERSION to 5.9.0

Summary:
Arguments in some QCOMPARE calls in KeyboardTranslatorTest had slightly
different types, what according to Qt documentation is not allowed.
The types of both QCOMPARE arguments must be exactly the same, otherwise
the code doesn't compile with some Qt versions.

With this fix it is safe to lower minimum Qt version to 5.9.0. Patch
number is incremented only for bugfix releases, so as long as invalid
code is not used everything should work.

The fix allows to compile Konsole using system libs on larger number
of systems, e.g. Ubuntu 18.04 LTS (Qt 5.9.5).

Tested with Qt 5.9.[0-5] and 5.11.1

Reviewers: Konsole, hindenburg

Reviewed By: Konsole, hindenburg

Subscribers: hindenburg, konsole-devel

Tags: Konsole

Differential Revision: https://phabricator.kde.org/D19859

Details

Committed
hindenburgMar 21 2019, 2:41 AM
Reviewer
Konsole
Differential Revision
D19859: Fix undefined behavior and set QT_MIN_VERSION to 5.9.0
Parents
R319:ed8847ec94a7: Set Qt minimum to 5.9.4
Branches
Unknown
Tags
Unknown