Use QTabBar: drop tons of code
9836d430253f
Actions

Authored by tcanabrava on Jul 17 2018, 2:24 PM.

Description

Use QTabBar: drop tons of code

Summary:
this is a WIP, I don't plan to merge this yet, there are many thigns to solve.

Drop the handmade TabWidget used inside of konsole in favor of Qt's QTabWidget
This drops tons of code we manually did, but it also drops a bit of functionality.

Everything besides detach should be working.
I'm now trying to finish detach.

a nice overvie:
15 files changed, 314 insertions(+), 1609 deletions(-)

Missing features:

Detach

and lots of testing.

Reviewers: hindenburg, Konsole, ngraham

Reviewed By: ngraham

Subscribers: ngraham, konsole-devel

Tags: Konsole

Differential Revision: https://phabricator.kde.org/D13882

Details

Committed

tcanabrava

Jul 18 2018, 7:34 AM

Reviewer

ngraham

Differential Revision

D13882: Use QTabBar: drop tons of code

Parents

R319:e94c3e3dfbf0: Fix size of TerminalDisplay on show
R319:3013bdb599c8: GIT_SILENT Upgrade KDE Applications version to 18.11.70.

Branches

Unknown

Tags

Unknown

tcanabrava committed R319:9836d430253f: Use QTabBar: drop tons of code (authored by tcanabrava).Jul 18 2018, 7:34 AM

Merged Changes

Commit		Author	Details	Committed
e94c3e3dfbf0	D13882	tcanabrava	Fix size of TerminalDisplay on show	Jul 17 2018
6248feb58206	D13882	tcanabrava	Show Quick Open button consistently	Jul 17 2018
9b9ff5c6cb06	D13882	tcanabrava	Readd closeAction	Jul 17 2018
94aeabbe10a4	D13882	tcanabrava	Fix detach from menu	Jul 17 2018
3f2bd3dca2a1	D13882	tcanabrava	Increase dead zone for detaching	Jul 17 2018
873edc5d4e7e	D13882	tcanabrava	Hint the cursor about a detach	Jul 17 2018
c92bbb953887	D13882	tcanabrava	Add tolerance for detach	Jul 17 2018
59b9fa51074a	D13882	tcanabrava	re-add detachTab	Jul 17 2018
8524890aa304	D13882	tcanabrava	Add currentTabIndex for easy menu access.	Jul 17 2018
8cc637f8b7d3	D13882	tcanabrava	New tab to manage the drag out of the tabbar	Jul 17 2018
494a1b32c85b	D13882	tcanabrava	Fix movement with keyboard	Jul 17 2018
93982ded1e09	D13882	tcanabrava	Re-Enable detaching actions	Jul 17 2018
39c35c2c9851	D13882	tcanabrava	Re-Enable dragging tabs	Jul 17 2018
a31adb4a26b0	D13882	tcanabrava	Fix Rename of tabs	Jul 17 2018
f91d84b381d5	D13882	tcanabrava	Remove replay signal.	Jul 17 2018
ec5ee406ffc5	D13882	tcanabrava	Re enable rename tab	Jul 17 2018
29dce00eda93	D13882	tcanabrava	Focus widget in currentChanged	Jul 17 2018
b4ef40dfa185	D13882	tcanabrava	Re enable close tabs, simplify code	Jul 17 2018
4c8c1b90f064	D13882	tcanabrava	Add the Close and New Tab Buttons	Jul 17 2018
4d73014a1c5e	D13882	tcanabrava	Remove Borders	Jul 17 2018
0e45cf058422	D13882	tcanabrava	Connect to KonsoleSettings directly	Jul 17 2018
b35546fd164b	D13882	tcanabrava	Restore TabBar visibility and position settings	Jul 17 2018
83ebda5bf4a3	D13882	tcanabrava	Use QTabBar: drop tons of code	Jul 17 2018

Changes (18)

				Path	Packages
	M			src/Application.cpp
	M			src/CMakeLists.txt
	A			src/DetachableTabBar.cpp
	A			src/DetachableTabBar.h
	M			src/MainWindow.cpp
	M			src/MainWindow.h
	M			src/Session.cpp
	M			src/Session.h
	M			src/SessionController.cpp
	M			src/TerminalDisplay.cpp
	M			src/ViewContainer.cpp
	M			src/ViewContainer.h
	D			src/ViewContainerTabBar.cpp
	D			src/ViewContainerTabBar.h
	M			src/ViewManager.cpp
	M			src/ViewManager.h
	M			src/ViewSplitter.cpp
	M			src/ViewSplitter.h