Fix an issue with a new tab focus

Authored by AndreyYashkin on Jul 28 2019, 2:16 PM.

Description

Fix an issue with a new tab focus

Summary:
When opening a new tab in the background and switching to that tab the focus is set on the location bar instead of the files view. If you switch back to the original tab and then to the new tab again focus will be set on the files view. The problem is caused by creation of DolphinTabPage in an active state which leads to skipping by return in DolphinView::setActive(bool active) without setting the focus on the view. This patch fixes this defect.

BUG: 407604
FIXED-IN: 19.11.80

Test Plan:

  1. Open a new tab in the background
  2. Switch to the new tab
  3. Check current focus widget by the up/down arrows on the keyboard with and without changes.

Reviewers: Dolphin, ngraham, elvisangelaccio

Reviewed By: ngraham

Subscribers: anthonyfieroni, ngraham, elvisangelaccio, kfm-devel

Tags: Dolphin

Differential Revision: https://phabricator.kde.org/D22386

Details

Committed
elvisangelaccioJul 28 2019, 2:18 PM
Reviewer
ngraham
Differential Revision
D22386: Fix an issue with a new tab focus
Parents
R318:e5c698f295c1: Merge branch 'Applications/19.08'
Branches
Unknown
Tags
Unknown