Show folder previews for items that have a Places Panel entry

Authored by ngraham on Apr 2 2018, 10:52 PM.

Description

Show folder previews for items that have a Places Panel entry

Summary:
informationpanelcontent.cpp currently has an explicit check for whether or not a URL has a Places panel entry, and if it does, no folder preview is generated. It's not clear why this is done, but it was reported as a bug: https://bugs.kde.org/show_bug.cgi?id=392621. Removing the logic fixes the bug.

BUG: 392621
FIXED-IN: 18.08.0

Test Plan:
Before:

After:

Detailed test procedure:

  • Open the Information Panel
  • Turn on previews
  • Put some pictures in ~/Pictures
  • Hover over it and see that the Information Panel shows a preview of its contents
  • Add ~/Pictures to the Places panel
  • Hover over it again and see that previews are no longer displayed
  • Apply the patch and restart Dolphin
  • Hover over it once more and see that there are now previews, yay!

Reviewers: Dolphin, markg, elvisangelaccio

Reviewed By: markg, elvisangelaccio

Subscribers: markg, broulik

Differential Revision: https://phabricator.kde.org/D11894

Details

Committed
ngrahamApr 3 2018, 10:39 PM
Reviewer
markg
Differential Revision
D11894: Show folder previews for items that have a Places Panel entry
Parents
R318:eab70b2ac4a8: Merge branch 'Applications/18.04'
Branches
Unknown
Tags
Unknown