Expose full set of script execution options in settings window

Authored by ngraham on Sep 26 2019, 6:31 PM.

Description

Expose full set of script execution options in settings window

Summary:
Right now the script execution setting is a checkbox, capable only of handling boolean
input. This is not appropriate because there are actually three options available.

Accordingly, this patch replaces the checkbox with a combobox (to save space compared
to radio buttons) that clearly exposes all three options.

BUG: 371837
FIXED-IN: 19.12.0

Test Plan:

  • All three options do what they say they'll do
  • All options get saved properly
  • The combobox displays the correct option when the window is loaded
  • The Defaults button resets it to "always ask" as expected

Reviewers: elvisangelaccio, Dolphin, VDG

Reviewed By: elvisangelaccio, Dolphin

Subscribers: kfm-devel

Tags: Dolphin

Maniphest Tasks: T9932

Differential Revision: https://phabricator.kde.org/D24247

Details

Committed
ngrahamSep 29 2019, 4:27 PM
Reviewer
Dolphin
Differential Revision
D24247: Expose full set of script execution options in settings window
Parents
R318:eec49bc38f4e: Add navigation history to forward/back buttons
Branches
Unknown
Tags
Unknown