Update window title after closing split view

Authored by rjennings on Apr 25 2018, 10:35 AM.

Description

Update window title after closing split view

Summary:

In dolphintabpage.cpp:

Through the connections set up in createViewContainer(), m_primaryViewContainer->setActive(true), at line 98,
ends up triggering slotViewActivated().

Because m_primaryViewActive is true, oldActiveView is not set to the view needed in this particular situation.
Both oldActiveView and newActiveView end up pointing to the same view and the connections are not set up.

BUG: 385111
FIXED-IN: 18.04.1

Test Plan:

  1. Open split view
  2. Make left panel active
  3. Close split view
  4. Navigate to various directories

Window title now updates to show current directory

Also tried with multiple tabs/combinations

Reviewers: Dolphin, ngraham

Reviewed By: Dolphin, ngraham

Subscribers: elvisangelaccio, ngraham

Differential Revision: https://phabricator.kde.org/D12446

Details

Committed
elvisangelaccioApr 25 2018, 10:37 AM
Reviewer
Dolphin
Differential Revision
D12446: Update window title after closing split view
Parents
R318:74c2d4ea2d25: Add failing test case for bug #385111
Branches
Unknown
Tags
Unknown