Note names: Fix width of notes on staff in different window sizes and position…

Authored by dmadaan on Aug 17 2017, 11:14 AM.

Description

Note names: Fix width of notes on staff in different window sizes and position of options grid to fit all notes

Details

Committed
dmadaanAug 17 2017, 11:14 AM
Parents
R2:7b89687d4986: Notenames: Add highlight of notes on staff in levels
Branches
Unknown
Tags
Unknown
Restricted Application added a subscriber: jjazeix. · View Herald TranscriptAug 17 2017, 11:17 AM
jjazeix added inline comments.Aug 17 2017, 7:58 PM
/src/activities/playpiano/Note.qml
116

are you sure it will still be working fine in playpiano with note of different duration?

dmadaan added inline comments.Aug 17 2017, 8:05 PM
/src/activities/playpiano/Note.qml
116

are their notes of duration > 500 ? Most of the logs I observed had duration as 500. It can be set to a max value of duration so that the note is highlighted before playing is finished. I have also observed their is some blank sound before note is played which makes it lag a little (that was the reason highlight was finished earlier then note sound)

jjazeix added inline comments.Aug 18 2017, 7:22 AM
/src/activities/playpiano/Note.qml
116

https://msu.edu/course/asc/232/song_project/dectalk_pages/note_to_%20ms.html
if we stop at displaying eighth notes, with a BPS of 60, the smallest duration is 500ms