piano_composition, 1. Rework code base according to new note notation. 2. Add higher octaves and lower octaves as planned. 3. Deleted old audio files. 4. Added new svg images for notes with ledger lines.
Description
Description
Details
Details
- Committed
amankumargupta May 21 2018, 3:32 PM - Parents
- R2:da104a92d578: piano_composition, make MultipleStaff flickable and add more staff when needed.
- Branches
- Unknown
- Tags
- Tasks
- T8743: piano_composition, update code-base with new notation, add higher and lower octaves and add new images with ledger lines.
| /src/activities/piano_composition/Piano.qml | ||
|---|---|---|
| 49 | A small spelling mistake in the comment. It will be "from" instead of "form". Same for below. | |
| /src/activities/piano_composition/MultipleStaff.qml | ||
|---|---|---|
| 109 | can you break when you find the note? I'm not sure how much they are, but it may take time for nothing | |
| /src/activities/piano_composition/NoteNotations.js | ||
| 3 | 2018 | |
| /src/activities/piano_composition/Piano.qml | ||
| 51 | you need to add a context for the translators here to tell them it's musical notes they are translating along with the octave | |
| /src/activities/piano_composition/Piano.qml | ||
|---|---|---|
| 51 | Yes, as the commit was already too big, I thought to add the context for translators in a fresh new commit as it will be easy to locate and clear for me when I look at the logs. | |
