Piano_composition: Append melodies during save

Authored by dmadaan on Aug 31 2017, 8:39 PM.

Description

Piano_composition: Append melodies during save

Details

Restricted Application added a subscriber: jjazeix. ยท View Herald TranscriptAug 31 2017, 8:41 PM
jjazeix added inline comments.Sep 1 2017, 7:42 AM
/src/activities/piano_composition/piano_composition.js
30

userDir should finish with the /, the userFile should just be the filename.

33

I would harmonize to clef everywhere even if both seems valid.

42

we should hamonize the end of sentence, always use a dot seems better.

72

if I'm not wrong, you'll append everytime you click on save meaning that you'll have twice the same music if you save it twice?
It would be better to let the child choose the name of the music, and if a music already have this title, prompt the child to overwrite it if he wants.

Needs to be checked for later, if an export to wav would be possible/interesting to have.

/src/core/File.cpp
120

copy/paste?

dmadaan added inline comments.Sep 1 2017, 5:40 PM
/src/activities/piano_composition/piano_composition.js
72

for now yes, its saved twice. Regarding the save yes I want to give it a name of child's choice :)
But then do we add a input text box to showMessageDialolg or should I create a new component with a button to save the file and pop another dialog if it exists to ask if it is to be overwrited?

But in this the child might get confused due to 1-2 windows :(

What do you think?

/src/core/File.cpp
120

yes, just used the append option instead (the write overwrites the file)