Piano_composition: Append melodies during save
Description
Description
Details
Details
- Committed
dmadaan Aug 31 2017, 8:39 PM - Parents
- R2:e3c732945a64: Piano_composition: Save melodies to json and indent and clean code
- Branches
- Unknown
- Tags
- References
- refs/backups/branch-playpiano-1542389433
/src/activities/piano_composition/piano_composition.js | ||
---|---|---|
30 | userDir should finish with the /, the userFile should just be the filename. | |
33 | I would harmonize to clef everywhere even if both seems valid. | |
42 | we should hamonize the end of sentence, always use a dot seems better. | |
72 | if I'm not wrong, you'll append everytime you click on save meaning that you'll have twice the same music if you save it twice? Needs to be checked for later, if an export to wav would be possible/interesting to have. | |
/src/core/File.cpp | ||
120 | copy/paste? |
/src/activities/piano_composition/piano_composition.js | ||
---|---|---|
72 | for now yes, its saved twice. Regarding the save yes I want to give it a name of child's choice :) But in this the child might get confused due to 1-2 windows :( What do you think? | |
/src/core/File.cpp | ||
120 | yes, just used the append option instead (the write overwrites the file) |