Diffusion GCompris 3960fa03786f

magic-hat, add multiple datasets
Concern Raised3960fa03786f
Actions

Authored by AkshayCHD on Jun 21 2019, 11:55 AM.

Description

magic-hat, add multiple datasets

Details

Auditors
scagarwal
Committed
AkshayCHDJun 21 2019, 11:55 AM
Differential Revision
D21893: magic-hat, add multiple datasets
Parents
R2:d98a2831c715: clockgame, add activity configuration to change dataset
Branches
Unknown
Tags
Unknown
scagarwal raised a concern with this commit.Jun 25 2019, 5:05 AM
scagarwal added a subscriber: scagarwal.
scagarwal added inline comments.
/src/activities/magic-hat-minus/magic-hat.js
36

Variable name is spelled wrong

37

Variable name is spelled wrong

38

Variable name is spelled wrong

57

It is not the issue, but better names are preferred. It helps the reader to get what this variable is for.

73

Reference to above comment.

This commit now has outstanding concerns.Jun 25 2019, 5:05 AM
AkshayCHD added a comment.Jun 25 2019, 5:10 AM

@scagarwal The issues that you mentioned have already been fixed, https://phabricator.kde.org/R2:1afe6395a94f92dc100583d4bbad0ad18be5f333, please pull the latest commits in the branch :)

Changes (24)

PathPackages
Msrc/activities/magic-hat-minus/ActivityInfo.qml
Msrc/activities/magic-hat-minus/MagicHat.qml
Msrc/activities/magic-hat-minus/StarsBar.qml
Msrc/activities/magic-hat-minus/magic-hat.js
A(dir)src/activities/magic-hat-minus/resource/1/
Psrc/activities/magic-hat-minus/resource/1/Data.qml
Copied from src/activities/reversecount/resource/1/Data.qml
A(dir)src/activities/magic-hat-minus/resource/2/
Asrc/activities/magic-hat-minus/resource/2/Data.qml
A(dir)src/activities/magic-hat-minus/resource/3/
Asrc/activities/magic-hat-minus/resource/3/Data.qml
A(dir)src/activities/magic-hat-minus/resource/4/
Psrc/activities/magic-hat-minus/resource/4/Data.qml
Copied from src/activities/clockgame/resource/2/Data.qml
A(dir)src/activities/magic-hat-minus/resource/5/
Psrc/activities/magic-hat-minus/resource/5/Data.qml
Copied from src/activities/algebra_by/resource/2/Data.qml
Msrc/activities/magic-hat-plus/ActivityInfo.qml
A(dir)src/activities/magic-hat-plus/resource/
A(dir)src/activities/magic-hat-plus/resource/1/
Psrc/activities/magic-hat-plus/resource/1/Data.qml
Copied from src/activities/algebra_by/resource/2/Data.qml
A(dir)src/activities/magic-hat-plus/resource/2/
Asrc/activities/magic-hat-plus/resource/2/Data.qml
A(dir)src/activities/magic-hat-plus/resource/3/
Asrc/activities/magic-hat-plus/resource/3/Data.qml
A(dir)src/activities/magic-hat-plus/resource/4/
Psrc/activities/magic-hat-plus/resource/4/Data.qml
Copied from src/activities/clockgame/resource/2/Data.qml

R2:3960fa03786f

View Options

src/activities/magic-hat-minus/ActivityInfo.qml

Loading...
View Options

src/activities/magic-hat-minus/MagicHat.qml

Loading...
View Options

src/activities/magic-hat-minus/StarsBar.qml

Loading...
View Options

src/activities/magic-hat-minus/magic-hat.js

Loading...
View Options

src/activities/magic-hat-minus/resource/1/Data.qml

Loading...
View Options

src/activities/magic-hat-minus/resource/2/Data.qml

Loading...
View Options

src/activities/magic-hat-minus/resource/3/Data.qml

Loading...
View Options

src/activities/magic-hat-minus/resource/4/Data.qml

Loading...
View Options

src/activities/magic-hat-minus/resource/5/Data.qml

Loading...
View Options

src/activities/magic-hat-plus/ActivityInfo.qml

Loading...
View Options

src/activities/magic-hat-plus/resource/1/Data.qml

Loading...
View Options

src/activities/magic-hat-plus/resource/2/Data.qml

Loading...
View Options

src/activities/magic-hat-plus/resource/3/Data.qml

Loading...
View Options

src/activities/magic-hat-plus/resource/4/Data.qml

Loading...