Diffusion GCompris 1abbc5b13361

drawing, fixed undo-redo tool
1abbc5b13361
Actions

Authored by asagtani on Jul 15 2018, 11:11 AM.

Description

drawing, fixed undo-redo tool

Details

Committed
asagtaniJul 15 2018, 11:11 AM
Parents
R2:40ae5060ca1e: drawing, minor fixes
Branches
Unknown
Tags
Unknown
Tasks
T9084: drawing, fix undo-redo tool
jjazeix added a subscriber: jjazeix.Jul 16 2018, 1:08 PM
jjazeix added inline comments.
/src/activities/drawing/drawing.js
321

why > 1 and not 0? Is there always an empty element inside?

337

just to be sure, but the button should be greyed and it should never happen?

357

same comment as above, should never happen?

asagtani marked 2 inline comments as done.Jul 17 2018, 2:52 PM
asagtani added inline comments.
/src/activities/drawing/drawing.js
321

yes, we have an empty canvas image url at index 0.

Changes (2)

PathPackages
Msrc/activities/drawing/Drawing.qml
Msrc/activities/drawing/drawing.js

R2:1abbc5b13361

View Options

src/activities/drawing/Drawing.qml

Loading...
View Options

src/activities/drawing/drawing.js

Loading...