Diffusion GCompris 0e226425df82

None names: Fix notes for bass and treble levels and fix staff size in small…
0e226425df82
Actions

Authored by dmadaan on Aug 11 2017, 8:10 AM.

Description

None names: Fix notes for bass and treble levels and fix staff size in small screen size

Details

Committed
dmadaanAug 11 2017, 8:10 AM
Parents
R2:31cb9baa0052: Note names: Fix highlight of notes and add play scale button
Branches
Unknown
Tags
Unknown
Restricted Application added a subscriber: jjazeix. · View Herald TranscriptAug 11 2017, 8:13 AM
jjazeix added inline comments.Aug 12 2017, 5:08 PM
/src/activities/note_names/note_names.js
112

it would be clearer to have a var clef = items.bar.level > 10 ? "bass" : "treble" and noteToPlay = 'qrc:/gcompris/src/activities/playpiano/resource/' + clef + '_pitches/' + '1' + '/' + notesToFind[items.score.currentSubLevel - 1] + '.wav'
So we know more easily the differency being sure it's the only difference between the 2 conditions (same for the others like that above in the diff)

115

why do you play it twice?

Changes (2)

PathPackages
Msrc/activities/note_names/NoteNames.qml
Msrc/activities/note_names/note_names.js

R2:0e226425df82

View Options

src/activities/note_names/NoteNames.qml

Loading...
View Options

src/activities/note_names/note_names.js

Loading...