Family Activity Completed

Authored by rkaur on Feb 9 2016, 6:31 PM.

Description

Family Activity Completed

Details

Committed
rkaurFeb 10 2016, 5:22 AM
Parents
R2:ce928f4d3b4b: With pictures level completed --level 17
Branches
Unknown
Tags
Unknown
References
refs/backups/branch-family-1456666939
Restricted Application added a subscriber: jjazeix. ยท View Herald TranscriptFeb 10 2016, 5:29 AM

I don't like the way the levels are defined. You have 4 arrays to describe a single level. Imagine I want to insert a level at the 5th position, it is easy to make a mistake. The correct way to do it is to have a single structure by level that holds the question, caption, answer , content and option. This way each qml item pick the right information from a single level array.

Also it would make it possible to randomize the entries for a given level.

It is also desirable to randomize the levels. But not too much to keep the difficulty increasing. So maybe use sublevel concept to have a single difficulty in a level propose sublevels randomly.

All texts to translate must be put in qsTr() e.g qsTr('Mother')

Hi,

I added also 2 comments.

Johnny

/src/activities/family/Family.qml
81

18 shouldn't be hardcoded (same for all the other ones)

190

you should not have qsTr() there because the content is not defined