Don't set a null completer on a non-editable combobox

Authored by elvisangelaccio on Mar 24 2019, 12:13 PM.

Description

Don't set a null completer on a non-editable combobox

Summary:
This was a no-op before and prints the following warning since 5.13:

Setting a QCompleter on non-editable QComboBox is not allowed.

See also https://codereview.qt-project.org/#/c/243045/4

Test Plan: Start dolphin with/without this patch.

Subscribers: kde-frameworks-devel

Tags: Frameworks

Differential Revision: https://phabricator.kde.org/D20016

Details

Committed
elvisangelaccioMar 24 2019, 3:51 PM
Differential Revision
D20016: Don't set a null completer on a non-editable combobox
Parents
R284:f4c4f29b93b3: It compiles fine without foreach
Branches
Unknown
Tags
Unknown