Fix issues reported by Krazy
Concern Raisede5c713da9e6f

Authored by tbaumgart on Jul 29 2018, 6:05 AM.

Description

Fix issues reported by Krazy

Details

Auditors
pino
Committed
tbaumgartJul 29 2018, 6:06 AM
Parents
R261:be1295489426: Try to fix SQLCipher on macOS
Branches
Unknown
Tags
Unknown
pino raised a concern with this commit.Jul 29 2018, 6:25 AM
pino added a subscriber: pino.
pino added inline comments.
/kmymoney/views/simpleledgerview.cpp
96–100

This code (with the change of this "krazy fix", without any detail in the commit message on the actual issue) is simply wrong: never ever use the UI text for anything else than showing it to the user. As also the comment says, accelerators can be added to it, for example.
A proper solution is to store the real data in some other form, for example a custom role in a model, a custom property in a QObject, an external QHash, etc.

This commit now has outstanding concerns.Jul 29 2018, 6:25 AM
tbaumgart marked an inline comment as done.Jul 29 2018, 9:31 AM
tbaumgart added inline comments.
/kmymoney/views/simpleledgerview.cpp
96–100