Fix check single-char QString operations for efficiency
Concern Raised6ebe577d80ee

Authored by wojnilowicz on Nov 26 2017, 10:50 AM.

Description

Fix check single-char QString operations for efficiency

Details

Auditors
christiand
Committed
wojnilowiczNov 26 2017, 12:09 PM
Parents
R261:9a1e4e92a2e7: Fix check for C++ ctors that should be declared 'explicit'
Branches
Unknown
Tags
Unknown
christiand raised a concern with this commit.Jan 30 2018, 6:27 PM
christiand added a subscriber: christiand.
christiand added inline comments.
/kmymoney/plugins/ofximport/dialogs/kofxdirectconnectdlg.cpp
101

Does this call insert \0-terminators into the QByteArray? The Qt Doc is not unambiguous here:

QByteArray &QByteArray::replace(const char *before, const char *after)

This is an overloaded function.

Replaces every occurrence of the string before with the string after.

This commit now has outstanding concerns.Jan 30 2018, 6:27 PM
wojnilowicz added inline comments.Jan 31 2018, 2:12 PM
/kmymoney/plugins/ofximport/dialogs/kofxdirectconnectdlg.cpp
101

What's the purpose of this question?