In R261:398304bcf331a322a0fe7e475775aea887c4b565#1999692, @christiand wrote:

Hello Lukasz,

I just imported several transactions using online banking. This caused several of this messages which are very meaningless in this case. Even worse, it is the second question I get after "Do you want to match the scheduled transaction.".

Even if I the transaction is entered manually, the dialog interrupts the process of entering something. Is this really what we want? Modern design tries to avoid modal dialogs for good reason.

Best,
Chris

Hi Christian!

I agree with you, but are you sure that this patch is to blame and there is no other place in the code that's faulty?
I mean this patch doesn't touch "Do you want to match the scheduled transaction." question and question about memory is asked only if memos of splits doesn't match. Even if you import through online banking, isn't it strange that splits belonging to one transaction have different memos right from the beginning?
I don't have possibility to test online banking myself. Maybe you have some test case that I could use.

Cheers
Łukasz

In R261:398304bcf331a322a0fe7e475775aea887c4b565#1999886, @wojnilowicz wrote:

[…]

Hi Lukasz,

you are right, the "Do you want to match the scheduled transaction."-dialog is not connected with this commit. The issue is that both dialogs may appear after each other and reference the same transaction (since both do not clearly say on which transaction they operate I cannot say this for sure). So the user might be asked twice about a single transaction. I wonder if we can reduce this number, preferably to zero because modal dialogs interrupt the workflow but I do not think this currently possible.

Unfortunately I do not know all details of the online banking import system or why this code is triggered at all, I mean it is part of an UI. The online banking should not use any UI but that is a different problem. A mockup online banking importer could be useful but it is not so easy, so this will need some time.

Back to this dialog/commit: When it is triggered? When I enter a transaction by hand I never had the issue that the text did not match. Does it only appear after duplicating or changing the text of an existing split?

Best
Chris

In R261:398304bcf331a322a0fe7e475775aea887c4b565#2000013, @christiand wrote:

In R261:398304bcf331a322a0fe7e475775aea887c4b565#1999886, @wojnilowicz wrote:

[…]

Hi Lukasz,

you are right, the "Do you want to match the scheduled transaction."-dialog is not connected with this commit. The issue is that both dialogs may appear after each other and reference the same transaction (since both do not clearly say on which transaction they operate I cannot say this for sure). So the user might be asked twice about a single transaction. I wonder if we can reduce this number, preferably to zero because modal dialogs interrupt the workflow but I do not think this currently possible.

That would be the best. I think I did something like that with CSV Importer lately.

Unfortunately I do not know all details of the online banking import system or why this code is triggered at all, I mean it is part of an UI. The online banking should not use any UI but that is a different problem. A mockup online banking importer could be useful but it is not so easy, so this will need some time.

Back to this dialog/commit: When it is triggered? When I enter a transaction by hand I never had the issue that the text did not match. Does it only appear after duplicating or changing the text of an existing split?

Did you follow bug 249844?