Use QStringLiteral/nullptr/override
Description
Description
Details
Details
- Auditors
rkflx - Committed
mlaurent Jul 26 2018, 11:41 AM - Parents
- R260:619dcde267fd: Always set transformation mode when setting zoom in image scaler
- Branches
- Unknown
- Tags
Comment Actions
This breaks the build, please fix: https://build.kde.org/job/Applications%20gwenview%20kf5-qt5%20FreeBSDQt5.10/63/console
Also, please coordinate with the Gwenview team before doing such large changes in the future, e.g. by opening a Diff on Phabricator.
(In particular, this makes merging stable to master more difficult for us for the whole lifetime of 18.08 and increases compile times when switching branches. As such, it's preferable to defer such changes to the time window between the last stable release (18.08.3) and the beta of the next major release (18.12).)
Comment Actions
@muhlenpfordt Did you get a notification about my last comment here? If not, perhaps you should consider adding yourself as a "Watcher" of the project…
Comment Actions
@lbeltrame fixed it for @mlaurent in 1cab13f0970f – Thanks.
Nevertheless, please go through Phabricator when proposing large changes for Gwenview in the future.
Comment Actions
Checked this now more thoroughly. There are a couple of unrelated changes that sneaked in, but it's mostly fine I guess.
We'll tackle some of the remaining Clazy and compiler warnings later.
| /lib/about.cpp | ||
|---|---|---|
| 39 | Unrelated change, now does not reflect the information from below anymore. | |
| /lib/documentview/documentview.cpp | ||
| 189 | Unrelated change. | |
| /lib/thumbnailview/thumbnailview.cpp | ||
| 263–274 | Unrelated change. | |
| 686 | Unrelated change. | |
| /lib/zoomslider.cpp | ||
| 56 | Unrelated change. | |