Respect custom filename for Copy/Move/Link To operations

Authored by rkflx on Jan 7 2018, 11:41 PM.

Description

Respect custom filename for Copy/Move/Link To operations

In copyMoveOrLink, 9056aa941e0d needed to strip the filename from
destUrl. However, this was done before the actual file operation had
been started, resulting in those being performed using the new target
directory, but with the old filename instead of a user-provided new
filename.

This regression can be fixed by moving the stripping after starting the
KIO job, because setting a new targetUrl in contextManager will only
be needed at a later point, i.e. when persisting this path to the
config.

BUG: 388144
FIXED-IN: 17.12.1

Test Plan: FileCopy To, enter custom filename, verify image is
copied to new path with new filename. Operations on multiple images
still work, as well as remembering the last used target directory in
both cases.

Details

Auditors
muhlenpfordt
Committed
rkflxJan 7 2018, 11:41 PM
Parents
R260:1a20e96b04da: GIT_SILENT Upgrade KDE Applications version to 17.12.1.
Branches
Unknown
Tags
Unknown
rkflx added a subscriber: muhlenpfordt.

@muhlenpfordt I promised to fix this for 17.12.1, but as this would need to go in by tomorrow and is pretty trivial, I already committed this. Still I'd appreciate it if you could have a short look, i.e. "audit" the commit – Thanks!

This commit now requires audit.Jan 7 2018, 11:52 PM
muhlenpfordt accepted this commit.Jan 8 2018, 8:10 AM

I can't spot any problems and all tests worked as expected. Looks good to me. :)

All concerns with this commit have now been addressed.Jan 8 2018, 8:10 AM