Diffusion Elisa c3cb65b73996

Implement new context view with metadata

Authored by mgallien on Apr 14 2019, 9:24 PM.

Description

Implement new context view with metadata

Summary:
enlarge the context view to fit new content

allow ManageHeaderBar to export a databaseId property for current track

in the detailed metadata view compose the property name with i18nc

partial upgrade of the database to better handle some missing metadata

do not always put a value for disc number when the metadata is not here

add back indexes when recreating Tracks table

allow comment of tracks to be null

store some metadata only if they are really defined

only really return data on tracks if they are not null in database

allow to inherit from TrackMetadataModel to filter properties

remove obsolete methods from TrackMetadataModel

introduce TrackContextMetadataModel to display metadata in context view

fix TrackMetadataModel to not create multiple connections

provide new context view with metadata from currently playing track

remove useless debug prints

fix size of the cover in context view

when showing ContextView, fix width to not overflow

add the filename at bottom of context view

fine tune the display of context view to be with regular spacing

Test Plan: context view mostly look like the design done by @januz

Reviewers: januz, ngraham, VDG

Reviewed By: ngraham, VDG

Subscribers: januz

Maniphest Tasks: T10330

Differential Revision: https://phabricator.kde.org/D18679

Merged Changes

CommitAuthorDetailsCommitted
3239643239b5D18679mgallien
change the way lyrics and other metadata are shown and improve lyrics 
Apr 14
951771dbc620D18679mgallien
ensure metadata is refreshed in context view when track changes 
Apr 14
67042c8fcd8eD18679mgallien
add support for fetching lyrics in TrackMetaDataModel and display it 
Apr 14
0e9abefea16aD18679mgallien
add possibility to handle Lyrics KFileMetaData property 
Apr 14
7457ddfe956dD18679mgallien
fix ContextView to no longer generate errors when shown 
Apr 14
8c75d1209692D18679mgallien
fix update of metadata model when a track change 
Apr 14
5d1b080c3727D18679mgallien
DatabaseInterface::trackHasStartedPlaying notify modified tracks 
Apr 14
b92110827ee6D18679mgallien
do not display disc number when only one disc 
Apr 14
2bf9cc7c808fD18679mgallien
adapt context view to tracks missing album name or artist name or both 
Apr 14
4c74ea0bc24cD18679mgallien
Implement new context view with metadata 
Apr 14
a79247b6100cD18679mgallien
add the filename at bottom of context view 
Apr 14
8ff4b7195ad8D18679mgallien
when showing ContextView, fix width to not overflow 
Apr 14
1322313da888D18679mgallien
fix size of the cover in context view 
Apr 14
ffe312f1bfd5D18679mgallien
remove useless debug prints 
Apr 14
3645b1f3a244D18679mgallien
provide new context view with metadata from currently playing track 
Apr 14
90f77ec8da3fD18679mgallien
fix TrackMetadataModel to not create multiple connections 
Apr 14
0193e73cd742D18679mgallien
introduce TrackContextMetadataModel to display metadata in context view 
Apr 14
d5bbc17e7f30D18679mgallien
remove obsolete methods from TrackMetadataModel 
Apr 14
c263529ed32eD18679mgallien
allow to inherit from TrackMetadataModel to filter properties 
Apr 14
83a262ab9825D18679mgallien
do not always put a value for disc number when the metadata is not here 
Apr 14
b466fbab044dD18679mgallien
in the detailed metadata view compose the property name with i18nc 
Apr 14
bddd9d74d640D18679mgallien
allow ManageHeaderBar to export a databaseId property for current track 
Apr 14
8687684e2ab3D18679mgallien
enlarge the context view to fit new content 
Apr 14