Diffusion Solid 3b642556c203

[UDevManager] Already filter for subsystem before querying
3b642556c203
Actions

Authored by broulik on Mar 13 2018, 4:00 PM.

Description

[UDevManager] Already filter for subsystem before querying

This does some rough filtering in advance before creating our wrapper items with properties and all.
UDev default 70-uaccess.rules assumes, ID_MEDIA_PLAYER is always in "usb" subsystem

CCBUG: 391738

Differential Revision: https://phabricator.kde.org/D11290

Details

Committed
broulikMar 13 2018, 4:00 PM
Differential Revision
D11290: [UDevManager] Already filter for subsystem before querying
Parents
R245:3fbf107732df: GIT_SILENT Upgrade KF5 version to 5.45.0.
Branches
Unknown
Tags
Unknown
bruns added a subscriber: bruns.May 28 2019, 10:04 PM
bruns added inline comments.
/src/solid/devices/backends/udev/udevmanager.cpp
184

Optimization opportunity:
device.parentUdi() is constant, UDEV_UDI_PREFIX, so the check can be moved up to 180 - if (parentUdi == UDEV_UDI_PREFIX)

203

always true, as you return on type == DeviceInterface::Unknown above.

but you should check for the remaining ones of supportedInterfaces - GenericInterface, Block (and Camera)

Changes (2)

PathPackages
Msrc/solid/devices/backends/udev/udevdevice.cpp
Msrc/solid/devices/backends/udev/udevmanager.cpp

R245:3b642556c203

View Options

src/solid/devices/backends/udev/udevdevice.cpp

Loading...
View Options

src/solid/devices/backends/udev/udevmanager.cpp

Loading...