Change reveal password button logic

Authored by GB_2 on Sep 9 2019, 3:48 PM.

Description

Change reveal password button logic

Summary:
Indicate state, not the action it will have. When the password field is empty it feels like the password will be shown once I start typing. Dolphin has been doing it this way for the "show hidden files" action forever.
Also only show the button when the field contains text or when revealing the password, like in the PolKit dialog.

Test Plan:
Empty field


Dolphin
Show hidden files, files are currently hidden


Hide hidden files, files are currently shown

Reviewers: Plasma, VDG, ngraham, broulik, ndavis

Reviewed By: VDG, ngraham, ndavis

Subscribers: ndavis, kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, starbuck, plasma-devel

Tags: Plasma, Frameworks

Differential Revision: https://phabricator.kde.org/D10362

Details

Committed
GB_2Sep 9 2019, 3:48 PM
Reviewer
VDG
Differential Revision
D10362: Change reveal password button logic
Parents
R242:c88354e0ed9b: API dox: add missing @since
Branches
Unknown
Tags
Unknown