Diffusion KIO e80c31163170

Use the new uds implementation

Authored by jtamate on May 10 2018, 5:24 PM.

Description

Use the new uds implementation

Summary:
KIO::UDSEntry, switch to a single std::vector for more performance.
This new implementation is the fastest in the autotests.
This new implementation has asserts in the insert() methods to detect an already inserted entry, in that case the insert() call must be changed into a replace() call.
Detected so far:

  • KFileItem::init(), setTime(), setLocalPath() because m_entry can have entries from the constructor.
  • KFileItem::setName, when renaming a file in dolphin.
  • ListJobPrivate::slotListEntries, running Kfind.

Test Plan:
It should be used extensively at least one release cycle before pushing it.

Passes the autotests.
Don't assert in any kde program that uses kio.

Reviewers: dfaure, Frameworks

Reviewed By: dfaure

Subscribers: kde-frameworks-devel, bruns

Tags: Frameworks

Differential Revision: https://phabricator.kde.org/D12696

Details

Committed
jtamateMay 10 2018, 5:25 PM
Reviewer
dfaure
Differential Revision
D12696: Use the new uds implementation
Parents
R241:2a57054a718a: Don't redirect smb:/ to smb:// and then to smb:///
Branches
Unknown
Tags
Unknown