Diffusion KIO 3154fc3e096e

Making FileJob behave consistently.

Authored by feverfew on Aug 30 2019, 9:15 AM.

Description

Making FileJob behave consistently.

Summary:
This patch does the following:

  1. Makes sure the close() signal is actually emitted when close() is called.
  2. Documents the FileJob functions more accurately, and ensures the file slave acts similarly to the two other slaves that implement these functions (smb/sftp).
  3. Fixes an issue when purposefully reading 0 bytes.
  4. Fixes a bug where finished() is called after error().

Test Plan:
The application I am developing on that depends on FileJob now successfully receives the close() signal when required and does not experience the bug
mentioned when reading 0 bytes.
Existing read/write/seek functionality is not broken.
Tests also pass.

Reviewers: dfaure, fvogt, chinmoyr, apol

Reviewed By: dfaure, chinmoyr

Subscribers: kde-frameworks-devel

Tags: Frameworks

Differential Revision: https://phabricator.kde.org/D23194

Details

Committed
feverfewAug 30 2019, 9:17 AM
Reviewer
dfaure
Differential Revision
D23194: Making FileJob behave consistently.
Parents
R241:976c2c022908: SVN_SILENT made messages (.desktop file) - always resolve ours
Branches
Unknown
Tags
Unknown