Fix removing cookies from KCookieServer

Authored by stefanocrocco on Sep 1 2018, 4:02 PM.

Description

Fix removing cookies from KCookieServer

Summary:
The call to KCookieServer::deleteCookies always failed because the
cookie name was passed as a QByteArray and not as a QString. This is now
corrected and tests are provided to check the correct behaviour.

The error check for a DBus error in the call to
KCookieServer::deleteCookies also was incorrect, since it called
QDBusAbstractInterface::lastError(), which isn't useful for non-blocking
calls. A correct check using QDBusPendingCall is now used.

Test Plan: run the autotests

Reviewers: dfaure

Reviewed By: dfaure

Differential Revision: https://phabricator.kde.org/D15753

Details

Committed
stefanocroccoOct 4 2018, 6:49 PM
Reviewer
dfaure
Differential Revision
D15753: Fix removing cookies from KCookieServer
Parents
R226:b6ccfae3336f: use QIcon::fromTheme() instead of QIcon()
Branches
Unknown
Tags
Unknown