Replace Q_FOREACH with C++11 range-for
c864267f04a3
Actions

Authored by jeanv on Jul 20 2017, 2:14 PM.

Description

Replace Q_FOREACH with C++11 range-for

Summary:
The use of Q_FOREACH is advised against (https://doc.qt.io/qt-5/qtglobal.html#Q_FOREACH) since Qt 5.7 and will eventually be removed from Qt.

I replaced all occurrences with the range-for loop introduced in C++11 (except for the one in daemon.cpp in deviceIdByName which might have a bug / typo in it).

I added const to the container or casted it with qAsConst when appropriate to avoid unnecessary copies.

(This is my first submission. I did all the unit tests, and they all passed but I don't know how to show it here.)

Reviewers: KDE Connect, nicolasfella, apol

Reviewed By: KDE Connect, nicolasfella, apol

Subscribers: albertvaka, apol, nicolasfella

Tags: KDE Connect

Differential Revision: https://phabricator.kde.org/D6724

Details

Committed

albertvaka

Jul 21 2017, 7:57 AM

Reviewer

KDE Connect

Differential Revision

D6724: Replace Q_FOREACH with C++11 range-for

Parents

R224:aa307803296c: SVN_SILENT made messages (.desktop file) - always resolve ours

Branches

Unknown

Tags

Unknown

albertvaka committed R224:c864267f04a3: Replace Q_FOREACH with C++11 range-for (authored by jeanv).Jul 21 2017, 7:57 AM

Changes (20)

				Path	Packages
	M			cli/kdeconnect-cli.cpp
	M			core/backends/bluetooth/bluetoothlinkprovider.cpp
	M			core/daemon.cpp
	M			core/device.cpp
	M			core/pluginloader.cpp
	M			fileitemactionplugin/sendfileitemaction.cpp
	M			interfaces/devicesmodel.cpp
	M			interfaces/notificationsmodel.cpp
	M			kio/kiokdeconnect.cpp
	M			plasmoid/declarativeplugin/responsewaiter.cpp
	M			plugins/mpriscontrol/mpriscontrolplugin.cpp
	M			plugins/notifications/notificationsdbusinterface.cpp
	M			plugins/pausemusic/pausemusicplugin.cpp
	M			plugins/runcommand/runcommand_config.cpp
	M			plugins/sendnotifications/notificationslistener.cpp
	M			tests/pluginloadtest.cpp
	M			tests/sendfiletest.cpp
	M			tests/testnotificationlistener.cpp
	M			tests/testsocketlinereader.cpp
	M			tests/testsslsocketlinereader.cpp