Make member variable names, & placement and * placement more coherent
72535ecf48db
Actions

Authored by jeanv on Sep 3 2017, 7:39 PM.

Description

Make member variable names, & placement and * placement more coherent

Summary:
Change all member variables to the form m_fooBar because it is the preferred form in Qt (it was half and half between this and mFooBar, and a minority didn't have anything).
Place all references and pointers on the side of the type since it is the majority.

Basically:

mFoo -> m_foo
foo -> m_foo (if it is a member variable)
Type &ref -> Type& ref
Type *ptr -> Type* ptr

Reviewers: KDE Connect, nicolasfella, albertvaka

Reviewed By: KDE Connect, nicolasfella, albertvaka

Subscribers: albertvaka, KDE Connect

Tags: KDE Connect

Differential Revision: https://phabricator.kde.org/D7312

Details

Committed

albertvaka

Sep 3 2017, 7:45 PM

Reviewer

KDE Connect

Differential Revision

D7312: Make member variable names, & placement and * placement more coherent

Parents

R224:5d4821fb9cf6: Only show notification title in plasmoid if different to app name

Branches

Unknown

Tags

Unknown

albertvaka committed R224:72535ecf48db: Make member variable names, & placement and * placement more coherent (authored by jeanv).Sep 3 2017, 7:45 PM

Changes (156)
Show All Changes

Very Large Commit

This commit is very large. Load each file individually.

				Path	Packages
	M			app/main.cpp
	M			app/org.kde.kdeconnect.app.desktop
	M			cli/kdeconnect-cli.cpp
	M			core/backends/bluetooth/bluetoothdownloadjob.cpp
	M			core/backends/bluetooth/bluetoothdownloadjob.h
	M			core/backends/bluetooth/bluetoothuploadjob.cpp
	M			core/backends/bluetooth/bluetoothuploadjob.h
	M			core/backends/devicelinereader.cpp
	M			core/backends/devicelinereader.h
	M			core/backends/devicelink.cpp
	M			core/backends/devicelink.h
	M			core/backends/lan/downloadjob.cpp
	M			core/backends/lan/downloadjob.h
	M			core/backends/lan/landevicelink.cpp
	M			core/backends/lan/landevicelink.h
	M			core/backends/lan/lanlinkprovider.cpp
	M			core/backends/lan/lanlinkprovider.h
	M			core/backends/lan/server.cpp
	M			core/backends/lan/socketlinereader.cpp
	M			core/backends/lan/socketlinereader.h
	M			core/backends/lan/uploadjob.cpp
	M			core/backends/lan/uploadjob.h
	M			core/backends/pairinghandler.cpp
	M			core/core_debug.cpp
	M			core/daemon.cpp
	M			core/daemon.h
	M			core/device.cpp
	M			core/device.h
	M			core/filetransferjob.cpp
	M			core/filetransferjob.h
	M			core/kdeconnectconfig.cpp
	M			core/kdeconnectconfig.h
	M			core/kdeconnectplugin.cpp
	M			core/kdeconnectpluginconfig.cpp
	M			core/networkpackage.cpp
	M			core/networkpackage.h
	M			core/pluginloader.cpp
	M			core/pluginloader.h
	M			daemon/kdeconnect.desktop
	M			daemon/kdeconnectd.desktop.cmake
	M			fileitemactionplugin/kdeconnectsendfile.desktop
	M			fileitemactionplugin/sendfileitemaction.cpp
	M			fileitemactionplugin/sendfileitemaction.h
	M			indicator/deviceindicator.h
	M			indicator/main.cpp
	M			indicator/org.kde.kdeconnect.nonplasma.desktop
	M			interfaces/dbusinterfaces.cpp
	M			interfaces/dbusinterfaces.h
	M			interfaces/devicesmodel.cpp
	M			interfaces/devicesmodel.h
	M			interfaces/devicessortproxymodel.cpp
	M			interfaces/devicessortproxymodel.h
	M			interfaces/modeltest.cpp
	M			interfaces/modeltest.h
	M			interfaces/notificationsmodel.cpp
	M			kcm/kcm.cpp
	M			kcm/kcm.h
	M			kcm/kcm_kdeconnect.desktop
	M			kcm/org.kde.kdeconnect.kcm.desktop
	M			kcmplugin/kdeconnectpluginkcm.cpp
	M			kio/kiokdeconnect.cpp
	M			kio/kiokdeconnect.h
	M			plasmoid/declarativeplugin/kdeconnectdeclarativeplugin.cpp
	M			plasmoid/declarativeplugin/kdeconnectdeclarativeplugin.h
	M			plasmoid/declarativeplugin/objectfactory.h
	M			plasmoid/declarativeplugin/processrunner.cpp
	M			plasmoid/declarativeplugin/processrunner.h
	M			plasmoid/declarativeplugin/responsewaiter.h
	M			plasmoid/package/metadata.desktop
	M			plugins/battery/batterydbusinterface.cpp
	M			plugins/battery/batterydbusinterface.h
	M			plugins/battery/batteryplugin.cpp
	M			plugins/battery/batteryplugin.h
	M			plugins/battery/kdeconnect_battery.json
	M			plugins/clipboard/clipboardplugin.cpp
	M			plugins/clipboard/clipboardplugin.h
	M			plugins/clipboard/kdeconnect_clipboard.json
	M			plugins/findmyphone/findmyphoneplugin.h
	M			plugins/findmyphone/kdeconnect_findmyphone.json
	M			plugins/kdeconnect.notifyrc
	M			plugins/kdeconnect_plugin.desktop
	M			plugins/lockdevice/kdeconnect_lockdevice.json
	M			plugins/lockdevice/lockdeviceplugin.h
	M			plugins/mousepad/kdeconnect_mousepad.json
	M			plugins/mousepad/mousepadplugin.cpp
	M			plugins/mousepad/mousepadplugin.h
	M			plugins/mousepad_windows/kdeconnect_mousepad.json
	M			plugins/mousepad_windows/mousepadplugin_windows.h
	M			plugins/mpriscontrol/kdeconnect_mpriscontrol.json
	M			plugins/mpriscontrol/mpriscontrolplugin.h
	M			plugins/mprisremote/kdeconnect_mprisremote.json
	M			plugins/mprisremote/mprisremoteplugin.h
	M			plugins/notifications/kdeconnect_notifications.json
	M			plugins/notifications/notification.cpp
	M			plugins/notifications/notification.h
	M			plugins/notifications/notificationsdbusinterface.cpp
	M			plugins/notifications/notificationsdbusinterface.h
	M			plugins/notifications/notificationsplugin.h
	M			plugins/notifications/sendreplydialog.cpp
	M			plugins/notifications/sendreplydialog.h
	M			plugins/pausemusic/kdeconnect_pausemusic.json
	M			plugins/pausemusic/kdeconnect_pausemusic_config.desktop
	M			plugins/pausemusic/pausemusic_config.cpp
	M			plugins/pausemusic/pausemusic_config.h
	M			plugins/pausemusic/pausemusicplugin.h
	M			plugins/ping/kdeconnect_ping.json
	M			plugins/ping/pingplugin.h
	M			plugins/remotecommands/kdeconnect_remotecommands.json
	M			plugins/remotecommands/remotecommandsplugin.cpp
	M			plugins/remotecommands/remotecommandsplugin.h
	M			plugins/remotecontrol/kdeconnect_remotecontrol.json
	M			plugins/remotecontrol/remotecontrolplugin.cpp
	M			plugins/remotecontrol/remotecontrolplugin.h
	M			plugins/remotekeyboard/kdeconnect_remotekeyboard.json
	M			plugins/remotekeyboard/remotekeyboardplugin.h
	M			plugins/runcommand/kdeconnect_runcommand.json
	M			plugins/runcommand/kdeconnect_runcommand_config.desktop
	M			plugins/runcommand/runcommand_config.cpp
	M			plugins/runcommand/runcommand_config.h
	M			plugins/runcommand/runcommandplugin.h
	M			plugins/screensaver-inhibit/kdeconnect_screensaver_inhibit.json
	M			plugins/screensaver-inhibit/screensaverinhibitplugin.h
	M			plugins/sendnotifications/kdeconnect_sendnotifications.json
	M			plugins/sendnotifications/kdeconnect_sendnotifications_config.desktop
	M			plugins/sendnotifications/notificationslistener.cpp
	M			plugins/sendnotifications/notificationslistener.h
	M			plugins/sendnotifications/notifyingapplication.cpp
	M			plugins/sendnotifications/notifyingapplication.h
	M			plugins/sendnotifications/notifyingapplicationmodel.cpp
	M			plugins/sendnotifications/notifyingapplicationmodel.h
	M			plugins/sendnotifications/sendnotifications_config.cpp
	M			plugins/sendnotifications/sendnotifications_config.h
	M			plugins/sendnotifications/sendnotificationsplugin.h
	M			plugins/sftp/kdeconnect_sftp.json
	M			plugins/sftp/mounter.h
	M			plugins/sftp/sftpplugin.cpp
	M			plugins/sftp/sftpplugin.h
	M			plugins/share/kdeconnect_share.json
	M			plugins/share/kdeconnect_share_config.desktop
	M			plugins/share/share_config.cpp
	M			plugins/share/share_config.h
	M			plugins/share/shareplugin.h
	M			plugins/telephony/kdeconnect_telephony.json
	M			plugins/telephony/sendsmsdialog.cpp
	M			plugins/telephony/sendsmsdialog.h
	M			plugins/telephony/telephonyplugin.cpp
	M			plugins/telephony/telephonyplugin.h
	M			tests/downloadjobtest.cpp
	M			tests/lanlinkprovidertest.cpp
	M			tests/networkpackagetests.cpp
	M			tests/pluginloadtest.cpp
	M			tests/sendfiletest.cpp
	M			tests/testnotificationlistener.cpp
	M			tests/testsocketlinereader.cpp
	M			tests/testsslsocketlinereader.cpp
	M			urlhandler/org.kde.kdeconnect.telhandler.desktop

Make member variable names, & placement and * placement more coherent72535ecf48dbActions

Description

Details

Changes (156)Show All Changes

Very Large Commit

R224:72535ecf48db

app/main.cpp

app/org.kde.kdeconnect.app.desktop

cli/kdeconnect-cli.cpp

core/backends/bluetooth/bluetoothdownloadjob.cpp

core/backends/bluetooth/bluetoothdownloadjob.h

core/backends/bluetooth/bluetoothuploadjob.cpp

core/backends/bluetooth/bluetoothuploadjob.h

core/backends/devicelinereader.cpp

core/backends/devicelinereader.h

core/backends/devicelink.cpp

core/backends/devicelink.h

core/backends/lan/downloadjob.cpp

core/backends/lan/downloadjob.h

core/backends/lan/landevicelink.cpp

core/backends/lan/landevicelink.h

core/backends/lan/lanlinkprovider.cpp

core/backends/lan/lanlinkprovider.h

core/backends/lan/server.cpp

core/backends/lan/socketlinereader.cpp

core/backends/lan/socketlinereader.h

core/backends/lan/uploadjob.cpp

core/backends/lan/uploadjob.h

core/backends/pairinghandler.cpp

core/core_debug.cpp

core/daemon.cpp

core/daemon.h

core/device.cpp

core/device.h

core/filetransferjob.cpp

core/filetransferjob.h

core/kdeconnectconfig.cpp

core/kdeconnectconfig.h

core/kdeconnectplugin.cpp

core/kdeconnectpluginconfig.cpp

core/networkpackage.cpp

core/networkpackage.h

core/pluginloader.cpp

core/pluginloader.h

daemon/kdeconnect.desktop

daemon/kdeconnectd.desktop.cmake

fileitemactionplugin/kdeconnectsendfile.desktop

fileitemactionplugin/sendfileitemaction.cpp

fileitemactionplugin/sendfileitemaction.h

indicator/deviceindicator.h

indicator/main.cpp

indicator/org.kde.kdeconnect.nonplasma.desktop

interfaces/dbusinterfaces.cpp

interfaces/dbusinterfaces.h

interfaces/devicesmodel.cpp

interfaces/devicesmodel.h

interfaces/devicessortproxymodel.cpp

interfaces/devicessortproxymodel.h

interfaces/modeltest.cpp

interfaces/modeltest.h

interfaces/notificationsmodel.cpp

kcm/kcm.cpp

kcm/kcm.h

kcm/kcm_kdeconnect.desktop

kcm/org.kde.kdeconnect.kcm.desktop

kcmplugin/kdeconnectpluginkcm.cpp

kio/kiokdeconnect.cpp

kio/kiokdeconnect.h

plasmoid/declarativeplugin/kdeconnectdeclarativeplugin.cpp

plasmoid/declarativeplugin/kdeconnectdeclarativeplugin.h

plasmoid/declarativeplugin/objectfactory.h

plasmoid/declarativeplugin/processrunner.cpp

plasmoid/declarativeplugin/processrunner.h

plasmoid/declarativeplugin/responsewaiter.h

plasmoid/package/metadata.desktop

plugins/battery/batterydbusinterface.cpp

plugins/battery/batterydbusinterface.h

plugins/battery/batteryplugin.cpp

plugins/battery/batteryplugin.h

plugins/battery/kdeconnect_battery.json

Make member variable names, & placement and * placement more coherent
72535ecf48db
Actions

Changes (156)
Show All Changes