Fix line annotation leader line angle

Authored by tobiasdeiminger on May 10 2019, 11:40 PM.

Description

Fix line annotation leader line angle

Summary:
For "Straight Line" annotations, the "Leader Lines" (if any) shall be perpendicular to the main line segment. Current code missed to consider page aspect ratio when calculating the main segment angle, which caused non-perpendicular leader lines.

Note: Bug is only visible with non-PDF documents (i.e. where Okular draws line annotation, instead of generator).

Before:

After:

Test Plan:

  • open a txt file, the generated page will have aspect ratio 3:4
  • configure a "Straight Line" annotation with long leader line
  • create a line annotation at 45 degree angle
  • check the leader line, it shall be perpendicular to the main line

Reviewers: sander

Reviewed By: sander

Subscribers: aacid, okular-devel

Tags: Okular

Differential Revision: https://phabricator.kde.org/D21136

Details

Committed
tobiasdeimingerMay 14 2019, 9:36 PM
Reviewer
sander
Differential Revision
D21136: Fix line annotation leader line angle
Parents
R223:ae96db80af97: GIT_SILENT made messages (after extraction)
Branches
Unknown
Tags
Unknown