Custom background color

Authored by ngraham on Oct 1 2017, 1:37 AM.

Description

Custom background color

Summary:
BUG: 182994

Adds an option to the config dialog that enables background color (the color around the displayed page) to be changed (while by default preserving the Qt toolkit selection as not to affect existing users).

Reasons for this change:
Accessibility, eye strain, aesthetic reasons, color displayed on monitor can affect power consumption (how: depends on display technology).
Many people want this change occording to Bugzilla and other sources.

Maintenance: Nearly no additional maintenance:
This is no new subsystem but a trivial feature with no complex code dependencies, and we are already showing a colour selection dialog and setting colours in other places in Okular.

Other less important information:
https://git.reviewboard.kde.org/r/130219/
https://mail.kde.org/pipermail/okular-devel/2017-September/025520.html

Test Plan:
Tested everything, it all works:
Toggled the custom background color, changed custom background color, removed okular settings file (with: "rm ~/.config/okular*") to verify it uses the usual qt theme colour by default (where the settings file remembered the custom color).

Reviewers: Okular, aacid, elvisangelaccio, rkflx, ngraham

Reviewed By: ngraham

Subscribers: aacid, ltoscano, ngraham

Tags: Okular

Differential Revision: https://phabricator.kde.org/D8051

Details

Committed
ngrahamOct 1 2017, 1:45 AM
Reviewer
ngraham
Differential Revision
D8051: Custom background color
Parents
R223:24b481658ed6: GIT_SILENT made messages (after extraction)
Branches
Unknown
Tags
Unknown
Reverted By
R223:d176914e637d: Revert "Custom background color"

@ngraham: Thanks for keeping on top of this Diff. Unfortunately, you did not commit this on behalf of @albertfreeman, but your own name (probably by accident). This is kind of an important problem from a licensing standpoint: Albert wrote the code and has the copyright to it. Also it is not nice to not get credited for a first contribution at all.

I would recommend to revert this (explain why in the commit message of the revert) and then commit again, but this time changing the author beforehand (see https://identity.kde.org or ask Albert for the mail address):

git commit --amend --no-edit --author "name <name@domain>"

Thanks :)
(I know I could just do it myself, but that's not the point hereā€¦)

Oops, sorry! Definitely an accident. Looks like Luigi already cleaned up my mess, though. I'll be more careful in the future