diff --git a/cmake/CodeQualityUtils.cmake b/cmake/CodeQualityUtils.cmake index 9135786eb..3c98e3d5a 100644 --- a/cmake/CodeQualityUtils.cmake +++ b/cmake/CodeQualityUtils.cmake @@ -1,25 +1,25 @@ # These tools are run (for now) only if BUILD_TESTING is ON # Another useful tool could be clazy compiler too # Run cppcheck on the code find_program(CPPCHECK_EXE NAMES cppcheck) if(CPPCHECK_EXE) set(CMAKE_CXX_CPPCHECK ${CPPCHECK_EXE}) list( APPEND CMAKE_CXX_CPPCHECK "--enable=all" "--inconclusive" "--force" "--inline-suppr" ) endif() # Run clang-tidy find_program(CLANG_TIDY_EXE NAMES clang-tidy) if(CLANG_TIDY_EXE) set(CMAKE_CXX_CLANG_TIDY ${CLANG_TIDY_EXE}) list( APPEND CMAKE_CXX_CLANG_TIDY - "-checks=*,-fuchsia*,-google*,-hicpp*,-llvm*,-cppcoreguidelines-*,-modernize-use-auto,-readability-braces-around-statements,-readability-static-accessed-through-instance,-readability-magic-numbers" + "-checks=*,-fuchsia*,-google*,-hicpp*,-llvm*,-cppcoreguidelines-*,-modernize-use-auto,-readability-*" ) endif() diff --git a/src/core/synth/linearSynthesis.cpp b/src/core/synth/linearSynthesis.cpp index 4c9c621a9..9d458426c 100644 --- a/src/core/synth/linearSynthesis.cpp +++ b/src/core/synth/linearSynthesis.cpp @@ -1,68 +1,68 @@ /* miniSynth - A Simple Software Synthesizer Copyright (C) 2015 Ville Räisänen This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program. If not, see . */ #include "linearSynthesis.h" #include LinearSynthesis::LinearSynthesis(unsigned int mode, unsigned int size) : Waveform(mode, size) { numHarmonics = 16; timbreAmplitudes = new int[numHarmonics]; timbrePhases = new int[numHarmonics]; timbreAmplitudes[0] = 100; } void LinearSynthesis::setTimbre(QVector &litudes, QVector &phases) { Q_ASSERT(amplitudes.size() == phases.size()); delete[] timbreAmplitudes; delete[] timbrePhases; numHarmonics = amplitudes.size(); timbreAmplitudes = new int[numHarmonics]; timbrePhases = new int[numHarmonics]; - for(int i = 0 ; i < numHarmonics ; ++ i) { + for(unsigned int i = 0 ; i < numHarmonics ; ++ i) { timbreAmplitudes[i] = amplitudes[i]; timbrePhases[i] = phases[i]; } } LinearSynthesis::~LinearSynthesis() { delete[] timbreAmplitudes; delete[] timbrePhases; } qreal LinearSynthesis::evalTimbre(qreal t) { qreal val = 0; for (unsigned int harm = 0; harm < numHarmonics; harm++) { int qa_int = timbreAmplitudes[harm]; int qp_int = timbrePhases[harm]; if (qa_int > 0) { qreal qa = (qreal)qa_int/100; qreal qp = (2*M_PI*(qreal)qp_int)/360; val += qa * eval(((qreal)harm + 1) * t - qp); } } return val; }