More interface stuttering work
838e52b555a1
Actions

Authored by malteveerman on Apr 12 2018, 4:23 PM.

Description

More interface stuttering work

Summary:
This includes the C++ implementation of the lyrics functionality, which is now async. Also includes a fix for SqlAlbumTest, which failed since my last stuttering revision.
The biggest change though is in CollectionTreeItemModelBase. It now loads an album's tracks in a Threadweaver job and CollectionSortFilterProxyModel filters unloaded albums. This makes the CollectionTreeView seem to grow when expanding an artist with many albums like "Various Artists" instead of freezing for a while depending on your collection size. The CollectionTreeView must be set to display album years for this to take effect.

Reviewers: Amarok, markey

Reviewed By: Amarok, markey

Subscribers: Amarok

Tags: Amarok

Differential Revision: https://phabricator.kde.org/D11968

Details

Committed

markey

Apr 12 2018, 4:32 PM

Reviewer

Amarok

Differential Revision

D11968: More interface stuttering work

Parents

R181:5886d821cb64: Try to fix the build for FreeBSD another way

Branches

Unknown

Tags

Unknown

markey committed R181:838e52b555a1: More interface stuttering work (authored by malteveerman).Apr 12 2018, 4:32 PM

Changes (101)

		Path
M		src/CMakeLists.txt
M		src/OpmlParser.h
M		src/OpmlWriter.h
M		src/amarokurls/BookmarkGroup.cpp
M		src/amarokurls/BookmarkModel.cpp
M		src/amarokurls/BookmarkTreeView.cpp
M		src/browsers/CollectionSortFilterProxyModel.cpp
M		src/browsers/CollectionSortFilterProxyModel.h
M		src/browsers/CollectionTreeItemModelBase.cpp
M		src/browsers/CollectionTreeItemModelBase.h
M		src/configdialog/ConfigDialog.h
M		src/configdialog/dialogs/CollectionConfig.h
M		src/configdialog/dialogs/DatabaseConfig.h
M		src/configdialog/dialogs/GeneralConfig.h
M		src/configdialog/dialogs/MetadataConfig.h
M		src/configdialog/dialogs/NotificationsConfig.h
M		src/configdialog/dialogs/PlaybackConfig.h
M		src/configdialog/dialogs/PluginsConfig.h
M		src/configdialog/dialogs/ScriptsConfig.h
M		src/context/AmarokContextPackageStructure.h
M		src/context/AppletModel.h
M		src/context/ContextView.cpp
D		src/context/LyricsManager.cpp
D		src/context/LyricsManager.h
M		src/context/applets/albums/plugin/AlbumItem.h
M		src/context/applets/albums/plugin/AlbumsModel.h
M		src/context/applets/albums/plugin/AlbumsPlugin.cpp
M		src/context/applets/albums/plugin/TrackItem.h
M		src/context/applets/analyzer/plugin/AnalyzerBase.cpp
M		src/context/applets/analyzer/plugin/AnalyzerBase.h
M		src/context/applets/analyzer/plugin/AnalyzerPlugin.cpp
M		src/context/applets/analyzer/plugin/BlockAnalyzer.h
M		src/context/applets/analyzer/plugin/BlockRenderer.h
M		src/context/applets/analyzer/plugin/BlockWorker.h
M		src/context/applets/currenttrack/plugin/CurrentPlugin.cpp
M		src/context/applets/info/plugin/InfoPlugin.cpp
M		src/context/applets/lyrics/plugin/LyricsEngine.cpp
M		src/context/applets/lyrics/plugin/LyricsEngine.h
M		src/context/applets/lyrics/plugin/LyricsPlugin.cpp
M		src/context/applets/photos/plugin/PhotosPlugin.cpp
M		src/context/applets/wikipedia/plugin/WikipediaPlugin.cpp
M		src/context/qml_plugin/src/PixmapItem.h
M		src/context/qml_plugin/src/Plugin.cpp
M		src/context/qml_plugin/src/RatingItem.h
M		src/core-impl/collections/daap/daapreader/Reader.h
M		src/core-impl/collections/db/sql/SqlMeta.cpp
M		src/core-impl/collections/db/sql/SqlMeta.h
M		src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.h
M		src/core-impl/collections/ipodcollection/jobs/IpodDeleteTracksJob.h
M		src/core-impl/collections/ipodcollection/jobs/IpodParseTracksJob.h
M		src/core-impl/collections/ipodcollection/jobs/IpodWriteDatabaseJob.h
M		src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.h
M		src/core-impl/collections/mediadevicecollection/playlist/MediaDeviceUserPlaylistProvider.cpp
M		src/core-impl/collections/mtpcollection/handler/MtpHandler.h
M		src/core-impl/collections/nepomukcollection/NepomukInquirer.h
M		src/core-impl/collections/playdarcollection/PlaydarCollection.cpp
M		src/core-impl/collections/support/MemoryQueryMaker.h
M		src/core-impl/collections/support/jobs/WriteTagsJob.h
M		src/core-impl/meta/proxy/MetaProxyWorker.h
M		src/core-impl/meta/timecode/TimecodeMeta.cpp
M		src/core-impl/playlists/types/file/PlaylistFileLoaderJob.h
M		src/core/support/Debug_p.h
M		src/covermanager/CoverFetchQueue.cpp
M		src/covermanager/CoverFetchQueue.h
M		src/covermanager/CoverFetcher.cpp
M		src/covermanager/CoverFetcher.h
M		src/dialogs/TagDialog.cpp
M		src/dialogs/TagDialog.h
M		src/dynamic/BiasSolver.h
A	(dir)	src/lyrics/
A		src/lyrics/LyricsManager.cpp
A		src/lyrics/LyricsManager.h
M		src/musicbrainz/MusicBrainzXmlParser.h
M		src/musicbrainz/MusicDNSAudioDecoder.h
M		src/musicbrainz/MusicDNSXmlParser.h
M		src/playlist/PlaylistController.cpp
M		src/playlistgenerator/ConstraintSolver.h
M		src/playlistmanager/PlaylistManager.cpp
M		src/scanner/AbstractDirectoryWatcher.h
M		src/scanner/GenericScannerJob.h
D		src/scripting/scriptengine/AmarokLyricsScript.cpp
D		src/scripting/scriptengine/AmarokLyricsScript.h
M		src/scripting/scriptmanager/ScriptItem.cpp
M		src/scripting/scripts/CMakeLists.txt
D		src/scripting/scripts/lyrics_lyricwiki
D		src/scripting/scripts/lyrics_lyricwiki/CMakeLists.txt
D		src/scripting/scripts/lyrics_lyricwiki/main.js
D		src/scripting/scripts/lyrics_lyricwiki/script.desktop
M		src/services/ServiceSqlQueryMaker.cpp
M		src/services/ampache/AmpacheSettings.h
M		src/services/gpodder/GpodderServiceSettings.h
M		src/services/jamendo/JamendoXmlParser.h
M		src/services/magnatune/MagnatuneDatabaseWorker.h
M		src/services/magnatune/MagnatuneInfoParser.cpp
M		src/services/magnatune/MagnatuneStore.cpp
M		src/services/magnatune/MagnatuneXmlParser.h
M		src/services/mp3tunes/Mp3tunesWorkers.h
M		src/statsyncing/jobs/MatchTracksJob.h
M		src/statsyncing/jobs/SynchronizeTracksJob.h
M		src/widgets/BoxWidget.h
M		src/widgets/PrettyTreeRoles.h

More interface stuttering work838e52b555a1Actions

Description

Details

Changes (101)

R181:838e52b555a1

src/CMakeLists.txt

src/OpmlParser.h

src/OpmlWriter.h

src/amarokurls/BookmarkGroup.cpp

src/amarokurls/BookmarkModel.cpp

src/amarokurls/BookmarkTreeView.cpp

src/browsers/CollectionSortFilterProxyModel.cpp

src/browsers/CollectionSortFilterProxyModel.h

src/browsers/CollectionTreeItemModelBase.cpp

src/browsers/CollectionTreeItemModelBase.h

src/configdialog/ConfigDialog.h

src/configdialog/dialogs/CollectionConfig.h

src/configdialog/dialogs/DatabaseConfig.h

src/configdialog/dialogs/GeneralConfig.h

src/configdialog/dialogs/MetadataConfig.h

src/configdialog/dialogs/NotificationsConfig.h

src/configdialog/dialogs/PlaybackConfig.h

src/configdialog/dialogs/PluginsConfig.h

src/configdialog/dialogs/ScriptsConfig.h

src/context/AmarokContextPackageStructure.h

src/context/AppletModel.h

src/context/ContextView.cpp

src/context/LyricsManager.cpp

src/context/LyricsManager.h

src/context/applets/albums/plugin/AlbumItem.h

src/context/applets/albums/plugin/AlbumsModel.h

src/context/applets/albums/plugin/AlbumsPlugin.cpp

src/context/applets/albums/plugin/TrackItem.h

src/context/applets/analyzer/plugin/AnalyzerBase.cpp

src/context/applets/analyzer/plugin/AnalyzerBase.h

src/context/applets/analyzer/plugin/AnalyzerPlugin.cpp

src/context/applets/analyzer/plugin/BlockAnalyzer.h

src/context/applets/analyzer/plugin/BlockRenderer.h

src/context/applets/analyzer/plugin/BlockWorker.h

src/context/applets/currenttrack/plugin/CurrentPlugin.cpp

src/context/applets/info/plugin/InfoPlugin.cpp

src/context/applets/lyrics/plugin/LyricsEngine.cpp

src/context/applets/lyrics/plugin/LyricsEngine.h

src/context/applets/lyrics/plugin/LyricsPlugin.cpp

src/context/applets/photos/plugin/PhotosPlugin.cpp

src/context/applets/wikipedia/plugin/WikipediaPlugin.cpp

src/context/qml_plugin/src/PixmapItem.h

src/context/qml_plugin/src/Plugin.cpp

src/context/qml_plugin/src/RatingItem.h

src/core-impl/collections/daap/daapreader/Reader.h

src/core-impl/collections/db/sql/SqlMeta.cpp

src/core-impl/collections/db/sql/SqlMeta.h

src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.h

src/core-impl/collections/ipodcollection/jobs/IpodDeleteTracksJob.h

src/core-impl/collections/ipodcollection/jobs/IpodParseTracksJob.h

src/core-impl/collections/ipodcollection/jobs/IpodWriteDatabaseJob.h

src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.h

src/core-impl/collections/mediadevicecollection/playlist/MediaDeviceUserPlaylistProvider.cpp

src/core-impl/collections/mtpcollection/handler/MtpHandler.h

src/core-impl/collections/nepomukcollection/NepomukInquirer.h

src/core-impl/collections/playdarcollection/PlaydarCollection.cpp

src/core-impl/collections/support/MemoryQueryMaker.h

src/core-impl/collections/support/jobs/WriteTagsJob.h

src/core-impl/meta/proxy/MetaProxyWorker.h

src/core-impl/meta/timecode/TimecodeMeta.cpp

src/core-impl/playlists/types/file/PlaylistFileLoaderJob.h

src/core/support/Debug_p.h

src/covermanager/CoverFetchQueue.cpp

src/covermanager/CoverFetchQueue.h

src/covermanager/CoverFetcher.cpp

src/covermanager/CoverFetcher.h

src/dialogs/TagDialog.cpp

src/dialogs/TagDialog.h

src/dynamic/BiasSolver.h

src/lyrics/LyricsManager.cpp

src/lyrics/LyricsManager.h

src/musicbrainz/MusicBrainzXmlParser.h

src/musicbrainz/MusicDNSAudioDecoder.h

src/musicbrainz/MusicDNSXmlParser.h

src/playlist/PlaylistController.cpp

More interface stuttering work
838e52b555a1
Actions