Port QML Rectangle cropper to QWidget + QPainter

Authored by abalaji on Dec 17 2018, 3:21 PM.

Description

Port QML Rectangle cropper to QWidget + QPainter

Summary:

  1. Port QML canvas based screenshot cropper to QWidget + QPainter based cropper
  2. Fix minor bugs with cropper while porting, like system font not being set for size indicator
  3. "Include mouse pointer" setting now blends the cursor into the screenshot right away, letting the user see it while cropping, rather than blending it in after cropping

Before:


After:

BUG: 394503
BUG: 374009

Test Plan: Compare with original cropper and check if I missed something

Reviewers: Spectacle, broulik, ngraham, alexeymin

Reviewed By: Spectacle, broulik, ngraham, alexeymin

Subscribers: alexeymin, kpiwowarski, broulik, sharvey, guotao, ngraham, rkflx, Spectacle

Tags: Spectacle

Differential Revision: https://phabricator.kde.org/D12626

Details

Committed
ngrahamDec 17 2018, 3:30 PM
Reviewer
Spectacle
Differential Revision
D12626: Port QML Rectangle cropper to QWidget + QPainter
Parents
R166:e5a221321df0: SVN_SILENT made messages (.desktop file) - always resolve ours
Branches
Unknown
Tags
Unknown