Improve on-screen help text for rectangular selection

Authored by rkflx on May 1 2018, 7:41 PM.

Description

Improve on-screen help text for rectangular selection

Summary:
D11599 adds a magnifier to the rectangular region selection screen, but
the corresponding help text on how to toggle the magnifier temporarily
is a bit hidden: Most users won't discover a mouse-over help text on a
checkbox in the config dialog.

To make the feature easier to notice, the corresponding text is added to
the on-screen help. As a prerequisite, the very long line of text is
first broken up into a more tabular style.

The second help text is also broken up and reworded. Both border styles are
adapted to slightly rounded corners.

Setting the default visibility of the help texts to false avoids
showing them initially for a brief moment.

Test Plan:
spectacle -r, observe help texts with Remember selected area set
to on and also to off.

Before:

After:

Reviewers: Spectacle, ngraham

Reviewed By: Spectacle, ngraham

Subscribers: guotao, ngraham

Differential Revision: https://phabricator.kde.org/D12617

Details

Committed
rkflxMay 1 2018, 8:13 PM
Reviewer
Spectacle
Differential Revision
D12617: Improve on-screen help text for rectangular selection
Parents
R166:790cb3fb2a97: Add magnifier for rectangle mode
Branches
Unknown
Tags
Unknown

Hey, guess I'm too late. Was testing this with Breeze dark and looks like the text turns white, rip{F5829848}

rkflx added a subscriber: ngraham.May 1 2018, 10:42 PM

@abalaji Thanks for testing and reporting ;)

@ngraham I guess that's because of the Text → Label change you talked me into. Any tips on how to get to the current background colour? (Should be possible via Qt only, shouldn't it?)

ngraham added a comment.EditedMay 1 2018, 10:47 PM

@abalaji Thanks for testing and reporting ;)

@ngraham I guess that's because of the Text → Label change you talked me into. Any tips on how to get to the current background colour? (Should be possible via Qt only, shouldn't it?)

If we had Kirigami, we could stop reinventing the wheel and just use InlineMessages, and all of these problems would go away. :) Barring that, what we should do here is get the default window background color instead of hardcoding that pale yellow color. This is easy if you have Kirigami, dunno off the top of my head how to do it with QML only (about to lose wifi on my train).

We can use the same trick we use for the selection size tooltip, and have a dark rectangle with light text with a dark theme

Going through a patch of wifi again. Looks like this will help: https://doc.qt.io/qt-5/qml-qtquick-systempalette.html

rkflx added a comment.May 1 2018, 10:53 PM

If we had Kirigami, we chould stop reinventing the wheel and just use InlineMessages, and all of these problems would go away. :)

That's the same as saying I have to use all of KF5, even if using plain Qt would be the way to go.

I think inline messages won't work that well, as there is no context / background to attach the inline message to. After all, notifications in Plasma are also not related to InlineMessages, aren't they?

Anyway, will continue tomorrow, thanks for the tips so far.