Optimize #include
Test Plan: If it compiles, all is fine.
Reviewers: Spectacle, rkflx
Reviewed By: Spectacle, rkflx
Subscribers: rkflx, Spectacle
Differential Revision: https://phabricator.kde.org/D11084
Description
Description
Details
Details
- Auditors
rkflx - Committed
rominf Mar 7 2018, 6:55 AM - Reviewer
- Spectacle
- Differential Revision
- D11084: Optimize #include
- Parents
- R166:3d1895a922f5: Capture reliably with compositing off regardless of screen size
- Branches
- Unknown
- Tags
Comment Actions
This is strange. It works on my machine:
build> git fetch origin
build> git co origin/master
HEAD is now at 3b69ac3 Optimize #include
build> git rev-parse HEAD
3b69ac3a7aff4dedd4a2578174f5465f02fcc02b
build> make clean; make -s -j5 >/dev/null
/data/romas/projects/spectacle/src/Main.cpp: In function ‘int main(int, char**)’:
/data/romas/projects/spectacle/src/Main.cpp:127:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
}
^
/data/romas/projects/spectacle/src/Main.cpp:128:5: note: here
case SpectacleCore::DBusMode:
^~~~
/data/romas/projects/spectacle/src/SpectacleCore.cpp: In member function ‘void SpectacleCore::screenshotFailed()’:
/data/romas/projects/spectacle/src/SpectacleCore.cpp:210:30: warning: this statement may fall through [-Wimplicit-fallthrough=]
showErrorMessage(i18n("Screenshot capture canceled or failed"));
~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/data/romas/projects/spectacle/src/SpectacleCore.cpp:211:5: note: here
case DBusMode:
^~~~
build>I'm confused.
Comment Actions
Yeah, on my machine it works too. But that's not enough, it has to work everywhere, especially on the CI.
Look at the Console Output on Jenkins.
| /src/Gui/KSMainWindow.cpp | ||
|---|---|---|
| 33 | Hint hint. | |