FakeCollectionScheduler => FakeIntervalCheck, so FakeAkonadiServer can return it
08438b04e96f
Actions

Authored by dfaure on Apr 15 2019, 8:47 PM.

Description

FakeCollectionScheduler => FakeIntervalCheck, so FakeAkonadiServer can return it

Summary:
This way AkonadiServer::instance()->intervalChecker() is never null
anymore, which simplifies some code at little bit, and will allow
testing how NotificationCollector interacts with IntervalCheck.

BTW CacheCleaner needs the if(), it's optional (null if configured away by user)

Test Plan: full "ctest"

Reviewers: dvratil

Reviewed By: dvratil

Subscribers: kde-pim

Tags: KDE PIM

Differential Revision: https://phabricator.kde.org/D20512

Details

Committed

dfaure

Apr 15 2019, 9:55 PM

Reviewer

dvratil

Differential Revision

D20512: FakeCollectionScheduler => FakeIntervalCheck, so FakeAkonadiServer can return it

Parents

R165:85d98e4e9250: CollectionScheduler: list all collections initially, not just those with…

Branches

Unknown

Tags

Unknown

dfaure committed R165:08438b04e96f: FakeCollectionScheduler => FakeIntervalCheck, so FakeAkonadiServer can return it (authored by dfaure).Apr 15 2019, 9:55 PM

Changes (12)

				Path	Packages
	M			autotests/server/CMakeLists.txt
	M			autotests/server/collectionschedulertest.cpp
	M			autotests/server/fakeakonadiserver.cpp
	V			autotests/server/{fakecollectionscheduler.cpp → fakeintervalcheck.cpp}
	V			autotests/server/{fakecollectionscheduler.h → fakeintervalcheck.h}
	V			autotests/server/{fakeintervalcheck.cpp ← fakecollectionscheduler.cpp}
	V			autotests/server/{fakeintervalcheck.h ← fakecollectionscheduler.h}
	M			src/server/akonadi.h
	M			src/server/cachecleaner.h
	M			src/server/handler/itemfetchhelper.cpp
	M			src/server/intervalcheck.h
	M			src/server/storage/notificationcollector.cpp