Use a more conventional sidebar header apparance in desktop view

Authored by ngraham on May 15 2019, 7:01 PM.

Description

Use a more conventional sidebar header apparance in desktop view

Summary:
Discover uses the Kirigami.GlobalDrawer for its navigation sidebar. This component is
designed to be used for showing global actions and hiding when not in use, and displays
a big banner image on top. This banner concept is borrowed from Android, which has the
same kind of global drawers full of actions with banners on top. So the concept is
somewhat familiar on mobile. However on the desktop, this "sidebar with banner image on
top" UI is not common and feels out of place, giving Discover an odd default appearance
since the sidebar is permanently visible but doesn't look like other apps' sidebars.

This patch adjusts the sidebar appearance to look and feel more conventional in the
desktop view, keeping the banner version only for the mobile view.

Test Plan:
Desktop view:


Mobile view:

(The extra space under the banner image is a pre-existing bug not introduced with this patch)

Now Discover's sidebar looks quite similar to System Settings' sidebar, which is very
visually appealing:

Reviewers: VDG, Discover Software Store, apol, ndavis

Reviewed By: VDG, Discover Software Store, apol, ndavis

Subscribers: filipf, ndavis, plasma-devel

Tags: Plasma

Differential Revision: https://phabricator.kde.org/D21234

Details

Committed
ngrahamMay 15 2019, 10:02 PM
Reviewer
VDG
Differential Revision
D21234: Use a more conventional sidebar header apparance in desktop view
Parents
R134:f2369a2d5c1c: Fix color deprecation warning
Branches
Unknown
Tags
Unknown