Don't commit the wl_surface from outside Qt code

Authored by davidedmundson on Jun 12 2019, 3:24 PM.

Description

Don't commit the wl_surface from outside Qt code

Plasma code calling wl_surface::commit outside of Qt's knowledge is
bound to lead to errors. We're going to cause kwin to configure a
surface before Qt has sent initial properties. Potentially causing
protocol violations.

This has the added benefit of blur and sliding being synced to the frame
correctly.

It does mean a user calling enableBlur/slide/backgroundContrast should
trigger a repaint in their code, but in all instances this happens
anyway.

Details

Committed
davidedmundsonOct 25 2019, 12:30 AM
Parents
R130:8339cba19e9a: [KWindowSystem] in icon() return realistic icon size
Branches
Unknown
Tags
Unknown
ognarb added a subscriber: ognarb.Nov 4 2019, 11:52 PM

Just for info, this patch was pushed we other (probably automated) commits.

That was well spotted! It wasn't intentional to push it with the clang format stuff, which is why it misses phab markers.

The commit itself is fine at least. I remember having Aleix review it when we were debugging some QtWayland thing ages. I think it's easier to leave rather than revert and put back.