update panel shadows when background hints are changed

Authored by mvourlakos on Nov 2 2019, 4:26 PM.

Description

update panel shadows when background hints are changed

Summary:
--when the containment background hints are updated then the
panel shadows should be also. In case the background hints
point to NoBackground the panel shadows should be removed
and in case they point to DefaultBackground they should be
drawn again
--PanelShadows::removeWindow has no place in updateEnabledBorders
because the window still lives. When removeWindow was executed
before it was faulty unregistered from PanelShadows and in order for
setEnabledBorders to work again we should need
to execute from start the PanelShadows::addWindow function

Test Plan:
--I have created an applet which a PlasmaComponents.Switch button
and toggles panel transparency on user demand easily

Reviewers: Plasma, davidedmundson, mart

Reviewed By: Plasma, davidedmundson

Subscribers: plasma-devel

Tags: Plasma

Differential Revision: https://phabricator.kde.org/D25121

Details

Committed
mvourlakosNov 6 2019, 4:03 PM
Reviewer
Plasma
Differential Revision
D25121: update panel shadows when background hints are changed
Parents
R120:b84075fad3fc: Merge branch 'Plasma/5.17'
Branches
Unknown
Tags
Unknown

@davidedmundson is it possible to cherry-pick this commit for Plasma/5.17 stable version ? will the system let me to do so?

@davidedmundson is it possible to cherry-pick this commit for Plasma/5.17 stable version ? will the system let me to do so?

I answer myself, it let me to do so for upcoming Plasma 5.17.3 with commit: https://phabricator.kde.org/R120:4c84ede8f8d0e0d7887965f959352deb84da1b73

It is, though the preferred course of action is to commit onto 5.17 first, then merge 5.17 into master. From git's POV that means we just have one ID which is easier to track.

It is, though the preferred course of action is to commit onto 5.17 first, then merge 5.17 into master. From git's POV that means we just have one ID which is easier to track.

sorry about that, it was the first time I commited in stable branch...
According to https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22 I should have branched from Plasma/5.17 for the commit and then use arc land. I did branched from Plasma/5.17 but the arc land decided to commit it to master. No idea why.