Fix editing items in SimpleFavoritesModel

Authored by fvogt on Oct 7 2017, 12:30 PM.

Description

Fix editing items in SimpleFavoritesModel

Summary:
tools.js is supposed to support both KaStatsFavoritesModel (used for
favorite applications) and SimpleFavoritesModel (used for system actions,
like poweroff/reboot/logout). The latter did not work though, as tools.js
unconditionally calls methods only present in KaStatsFavoritesModel.
This commit makes KaStatsFavoritesModel API compatible to SimpleFavoritesModel
and changes the relevant code in tools.js to support both.

Additionally, this syncs applets/kickoff/package/contents/code/tools.js again.

BUG: 385463

Test Plan:
Before this patch it wasn't possible to remove system actions from
the favorites bar.

Reviewers: Plasma, davidedmundson

Reviewed By: Plasma, davidedmundson

Subscribers: hein, davidedmundson, rikmills, plasma-devel

Tags: Plasma

Differential Revision: https://phabricator.kde.org/D8178

Details

Committed
fvogtOct 10 2017, 4:53 PM
Reviewer
Plasma
Differential Revision
D8178: Fix editing items in SimpleFavoritesModel
Parents
R120:c311339e14b3: Per-activity favorites (Final, again?)
Branches
Unknown
Tags
Unknown