use opacity instead of visible

Authored by mart on Mar 6 2018, 3:48 PM.

Description

use opacity instead of visible

Summary:
Qt documentation recomends to bind to opacity instead of visible as visible
cascades down. The tabbar used to trigger its height behavior anim when the
popup got hidden, binding to opacity (even if opacity isn't animated) is a
more correct behavior.
Plus with visible it triggers the Qt bug https://bugreports.qt.io/browse/QTBUG-66907
which in turn triggers https://bugs.kde.org/show_bug.cgi?id=391432

BUG:391432

Test Plan: kickoff never opens the last tab anymore

Reviewers: Plasma, davidedmundson

Reviewed By: Plasma, davidedmundson

Subscribers: plasma-devel

Tags: Plasma

Differential Revision: https://phabricator.kde.org/D11098

Details

Committed
martMar 6 2018, 4:02 PM
Reviewer
Plasma
Differential Revision
D11098: use opacity instead of visible
Parents
R119:6ec09f47d5ca: Update version number for 5.12.3 GIT_SILENT
Branches
Unknown
Tags
Unknown