don't set a user if there is no user

Authored by sitter on Oct 17 2018, 3:16 PM.

Description

don't set a user if there is no user

Summary:
it doesn't have technical downsides but ends up creating urls of the type

scheme://@host/path

which is technically equal to scheme://host/path, so the excess @ is really
just not necessary. simply check if the username is empty and if so
do not set a username on the QUrl

Test Plan:

  • no useless @
  • setting up fish connection with and without username still works (without defaults to local username)

Reviewers: broulik

Reviewed By: broulik

Subscribers: plasma-devel

Tags: Plasma

Differential Revision: https://phabricator.kde.org/D16275

Details

Committed
sitterOct 17 2018, 3:32 PM
Reviewer
broulik
Differential Revision
D16275: don't set a user if there is no user
Parents
R119:53255b7854eb: port knetattach from kurl to qurl
Branches
Unknown
Tags
Unknown